]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
watchdog: octeon: Handle the FROZEN hot plug notifier actions.
authorRichard Cochran <rcochran@linutronix.de>
Fri, 18 Mar 2016 21:26:08 +0000 (22:26 +0100)
committerWim Van Sebroeck <wim@iguana.be>
Sat, 14 May 2016 07:22:21 +0000 (09:22 +0200)
When performing a suspend operation, the kernel brings all of the
non-boot CPUs offline, calling the hot plug notifiers with the flag,
CPU_TASKS_FROZEN, set in the action code.  Similarly, during resume,
the CPUs are brought back online, but again the notifiers have the
FROZEN flag set.

While some very few drivers really need to treat suspend/resume
specially, this driver unintentionally ignores the notifications.

This patch changes the driver to disable the watchdog interrupt
whenever the CPU goes offline, and to enable it whenever the CPU goes
back online.  As a result, the suspended state is no longer a special
case that leaves the watchdog active.

Signed-off-by: Richard Cochran <rcochran@linutronix.de>
Cc: linux-watchdog@vger.kernel.org
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Wim Van Sebroeck <wim@iguana.be>
drivers/watchdog/octeon-wdt-main.c

index 14521c8b3d5a81916cc04d9b6e7d242837c2e678..b55981f88a08334328d409eff8badba7606908be 100644 (file)
@@ -431,7 +431,7 @@ static int octeon_wdt_cpu_callback(struct notifier_block *nfb,
 {
        unsigned int cpu = (unsigned long)hcpu;
 
-       switch (action) {
+       switch (action & ~CPU_TASKS_FROZEN) {
        case CPU_DOWN_PREPARE:
                octeon_wdt_disable_interrupt(cpu);
                break;