]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
ASoC: audio-graph-card: add missing const at graph_get_dai_id()
authorKuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Thu, 11 Jul 2019 04:10:45 +0000 (13:10 +0900)
committerMark Brown <broonie@kernel.org>
Thu, 11 Jul 2019 11:27:29 +0000 (12:27 +0100)
commit c152f8491a8d9 ("ASoC: audio-graph-card: fix an use-after-free in
graph_get_dai_id()") fixups use-after-free issue,
but, it need to use "const" for reg. This patch adds it.

We will have below without this patch

LINUX/sound/soc/generic/audio-graph-card.c: In function 'graph_get_dai_id':
LINUX/sound/soc/generic/audio-graph-card.c:87:7: warning: assignment discards\
 'const' qualifier from pointer target type [-Wdiscarded-qualifiers]
   reg = of_get_property(node, "reg", NULL);

Fixes: c152f8491a8d9 ("ASoC: audio-graph-card: fix an use-after-free in graph_get_dai_id()")
Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Acked-by: Wen Yang <wen.yang99@zte.com.cn>
Link: https://lore.kernel.org/r/87sgrd43ja.wl-kuninori.morimoto.gx@renesas.com
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/generic/audio-graph-card.c

index 343ede8042c3f5615cf1d6722f2f03d289574b0e..ebf2ca3249cb9197bfe0d21e16361430cc6f4c80 100644 (file)
@@ -63,7 +63,7 @@ static int graph_get_dai_id(struct device_node *ep)
        struct device_node *endpoint;
        struct of_endpoint info;
        int i, id;
-       u32 *reg;
+       const u32 *reg;
        int ret;
 
        /* use driver specified DAI ID if exist */