]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
tty: serial: qcom_geni_serial: Return IRQ_NONE for spurious interrupts
authorKarthikeyan Ramasubramanian <kramasub@codeaurora.org>
Thu, 3 May 2018 20:14:39 +0000 (14:14 -0600)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 14 May 2018 11:44:55 +0000 (13:44 +0200)
Currently the driver returns IRQ_HANDLED when spurious interrupts happen.
This is misleading. Fix the behavior by returning IRQ_NONE for spurious
interrupts.

Signed-off-by: Karthikeyan Ramasubramanian <kramasub@codeaurora.org>
Reviewed-by: Matthias Kaehlcke <mka@chromium.org>
Reviewed-by: Stephen Boyd <swboyd@chromium.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/tty/serial/qcom_geni_serial.c

index b0758606b6762e9eadec2f1f05805f16f3bfc381..8b706b0f3723cc578c45b313f699d90cb050ae24 100644 (file)
@@ -633,7 +633,7 @@ static irqreturn_t qcom_geni_serial_isr(int isr, void *dev)
        struct qcom_geni_serial_port *port = to_dev_port(uport, uport);
 
        if (uport->suspended)
-               return IRQ_HANDLED;
+               return IRQ_NONE;
 
        spin_lock_irqsave(&uport->lock, flags);
        m_irq_status = readl_relaxed(uport->membase + SE_GENI_M_IRQ_STATUS);