]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
staging: kpc2000: introduce usage of __packed
authorFabian Krueger <fabian.krueger@fau.de>
Wed, 26 Jun 2019 07:35:21 +0000 (09:35 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 1 Jul 2019 07:19:27 +0000 (09:19 +0200)
Replaced __attribute__((packed)) with __packed. Both ways of attributing
are equivalent, but being shorter, __packed should be preferred.
This refactoring makes the core more readable.

Signed-off-by: Fabian Krueger <fabian.krueger@fau.de>
Signed-off-by: Michael Scheiderer <michael.scheiderer@fau.de>
Cc: <linux-kernel@i4.cs.fau.de>
Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/kpc2000/kpc2000_spi.c

index 30073440189e2b5ad0ecd2faab8bbf977d227b70..7800d647db5087b965a79437231107921c735ad5 100644 (file)
@@ -114,7 +114,7 @@ struct kp_spi_controller_state {
 
 union kp_spi_config {
        /* use this to access individual elements */
-       struct __attribute__((packed)) spi_config_bitfield {
+       struct __packed spi_config_bitfield {
                unsigned int pha       : 1; /* spim_clk Phase      */
                unsigned int pol       : 1; /* spim_clk Polarity   */
                unsigned int epol      : 1; /* spim_csx Polarity   */
@@ -133,7 +133,7 @@ union kp_spi_config {
 };
 
 union kp_spi_status {
-       struct __attribute__((packed)) spi_status_bitfield {
+       struct __packed spi_status_bitfield {
                unsigned int rx    :  1; /* Rx Status       */
                unsigned int tx    :  1; /* Tx Status       */
                unsigned int eo    :  1; /* End of Transfer */
@@ -148,7 +148,7 @@ union kp_spi_status {
 };
 
 union kp_spi_ffctrl {
-       struct __attribute__((packed)) spi_ffctrl_bitfield {
+       struct __packed spi_ffctrl_bitfield {
                unsigned int ffstart :  1; /* FIFO Start */
                unsigned int         : 31;
        } bitfield;