]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
clk: mvebu: Use kcalloc() in two functions
authorMarkus Elfring <elfring@users.sourceforge.net>
Wed, 19 Apr 2017 19:08:54 +0000 (21:08 +0200)
committerStephen Boyd <sboyd@codeaurora.org>
Sat, 22 Apr 2017 02:49:34 +0000 (19:49 -0700)
* Multiplications for the size determination of memory allocations
  indicated that array data structures should be processed.
  Thus use the corresponding function "kcalloc".

  This issue was detected by using the Coccinelle software.

* Replace the specification of data types by pointer dereferences
  to make the corresponding size determination a bit safer according to
  the Linux coding style convention.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
drivers/clk/mvebu/common.c

index 66be2e0c82b488df5c8be50d1f0bd28367e4eb5d..472c88b90256945e1d70b7c5574a6b38a237c432 100644 (file)
@@ -126,7 +126,7 @@ void __init mvebu_coreclk_setup(struct device_node *np,
        if (desc->get_refclk_freq)
                clk_data.clk_num += 1;
 
-       clk_data.clks = kzalloc(clk_data.clk_num * sizeof(struct clk *),
+       clk_data.clks = kcalloc(clk_data.clk_num, sizeof(*clk_data.clks),
                                GFP_KERNEL);
        if (WARN_ON(!clk_data.clks)) {
                iounmap(base);
@@ -270,7 +270,7 @@ void __init mvebu_clk_gating_setup(struct device_node *np,
                n++;
 
        ctrl->num_gates = n;
-       ctrl->gates = kzalloc(ctrl->num_gates * sizeof(struct clk *),
+       ctrl->gates = kcalloc(ctrl->num_gates, sizeof(*ctrl->gates),
                              GFP_KERNEL);
        if (WARN_ON(!ctrl->gates))
                goto gates_out;