]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
staging: ks7010: Delete unnecessary assignments for buffer variables
authorMarkus Elfring <elfring@users.sourceforge.net>
Sun, 17 Jul 2016 11:38:46 +0000 (13:38 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 15 Aug 2016 14:34:18 +0000 (16:34 +0200)
A few variables were assigned a null pointer despite of the detail
that they were immediately reassigned by the following statement.
Thus remove such unnecessary assignments.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Reviewed-by: Wolfram Sang <wsa@the-dreams.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/ks7010/ks7010_sdio.c

index 7da6c841e2ccfb2a649603edd3fa4357e301576f..3622fba8fd36fc9c282ce2202755cd2fb1f7b8eb 100644 (file)
@@ -711,7 +711,6 @@ static int ks7010_sdio_update_index(struct ks_wlan_private *priv, u32 index)
        int rc = 0;
        int retval;
        unsigned char *data_buf;
-       data_buf = NULL;
 
        data_buf = kmalloc(sizeof(u32), GFP_KERNEL);
        if (!data_buf) {
@@ -743,7 +742,7 @@ static int ks7010_sdio_data_compare(struct ks_wlan_private *priv, u32 address,
        int rc = 0;
        int retval;
        unsigned char *read_buf;
-       read_buf = NULL;
+
        read_buf = kmalloc(ROM_BUFF_SIZE, GFP_KERNEL);
        if (!read_buf) {
                rc = 1;
@@ -776,8 +775,6 @@ static int ks7010_upload_firmware(struct ks_wlan_private *priv,
        int length;
        const struct firmware *fw_entry = NULL;
 
-       rom_buf = NULL;
-
        /* buffer allocate */
        rom_buf = kmalloc(ROM_BUFF_SIZE, GFP_KERNEL);
        if (!rom_buf) {