]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
ALSA: echoaudio: Mark expected switch fall-throughs
authorGustavo A. R. Silva <gustavo@embeddedor.com>
Sat, 4 Aug 2018 20:13:26 +0000 (15:13 -0500)
committerTakashi Iwai <tiwai@suse.de>
Mon, 6 Aug 2018 07:33:45 +0000 (09:33 +0200)
In preparation to enabling -Wimplicit-fallthrough, mark switch cases
where we are expecting to fall through.

Addresses-Coverity-ID: 115156 ("Missing break in switch")
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/pci/echoaudio/echoaudio.c

index 358ef7dcf4105f2a20666d4da87362ba0af2e0db..907cf1a467128bf44256da495d1d9e76d2f11498 100644 (file)
@@ -713,6 +713,7 @@ static int pcm_prepare(struct snd_pcm_substream *substream)
                break;
        case SNDRV_PCM_FORMAT_S32_BE:
                format.data_are_bigendian = 1;
+               /* fall through */
        case SNDRV_PCM_FORMAT_S32_LE:
                format.bits_per_sample = 32;
                break;
@@ -764,6 +765,7 @@ static int pcm_trigger(struct snd_pcm_substream *substream, int cmd)
                                        pipe->last_counter = 0;
                                        pipe->position = 0;
                                        *pipe->dma_counter = 0;
+                                       /* fall through */
                                case PIPE_STATE_PAUSED:
                                        pipe->state = PIPE_STATE_STARTED;
                                        break;