]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
rtc: s35390a: Change buf's type to u8 in s35390a_init
authorNathan Chancellor <natechancellor@gmail.com>
Fri, 19 Oct 2018 20:43:45 +0000 (13:43 -0700)
committerAlexandre Belloni <alexandre.belloni@bootlin.com>
Mon, 22 Oct 2018 17:29:43 +0000 (19:29 +0200)
Clang warns:

drivers/rtc/rtc-s35390a.c:124:27: warning: implicit conversion from
'int' to 'char' changes value from 192 to -64 [-Wconstant-conversion]
        buf = S35390A_FLAG_RESET | S35390A_FLAG_24H;
            ~ ~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~
1 warning generated.

Update buf to be an unsigned 8-bit integer, which matches the buf member
in struct i2c_msg.

https://github.com/ClangBuiltLinux/linux/issues/145
Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
drivers/rtc/rtc-s35390a.c

index 77feb603cd4c0b363cf57abad36fb03b30f61cb7..3c64dbb08109acd6951d2b9fb4e6c85252e537e9 100644 (file)
@@ -108,7 +108,7 @@ static int s35390a_get_reg(struct s35390a *s35390a, int reg, char *buf, int len)
 
 static int s35390a_init(struct s35390a *s35390a)
 {
-       char buf;
+       u8 buf;
        int ret;
        unsigned initcount = 0;