]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
media: imx-pxp: Check the return value from clk_prepare_enable()
authorFabio Estevam <festevam@gmail.com>
Tue, 6 Nov 2018 10:16:03 +0000 (05:16 -0500)
committerMauro Carvalho Chehab <mchehab+samsung@kernel.org>
Fri, 23 Nov 2018 10:36:58 +0000 (05:36 -0500)
clk_prepare_enable() may fail, so we should better check its return value
and propagate it in the case of error.

Signed-off-by: Fabio Estevam <festevam@gmail.com>
Reviewed-by: Philipp Zabel <p.zabel@pengutronix.de>
Signed-off-by: Hans Verkuil <hansverk@cisco.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
drivers/media/platform/imx-pxp.c

index b76cd0e8313c81e1fb30a4584695f823f59aa24d..27780f174c449a871ef2d1943c53728dd613af47 100644 (file)
@@ -1666,7 +1666,10 @@ static int pxp_probe(struct platform_device *pdev)
                return ret;
        }
 
-       clk_prepare_enable(dev->clk);
+       ret = clk_prepare_enable(dev->clk);
+       if (ret < 0)
+               return ret;
+
        pxp_soft_reset(dev);
 
        spin_lock_init(&dev->irqlock);