]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
optee: fix invalid of_node_put() in optee_driver_init()
authorJens Wiklander <jens.wiklander@linaro.org>
Mon, 9 Oct 2017 09:11:49 +0000 (11:11 +0200)
committerJens Wiklander <jens.wiklander@linaro.org>
Wed, 29 Nov 2017 09:24:57 +0000 (10:24 +0100)
The first node supplied to of_find_matching_node() has its reference
counter decreased as part of call to that function. In optee_driver_init()
after calling of_find_matching_node() it's invalid to call of_node_put() on
the supplied node again.

So remove the invalid call to of_node_put().

Reported-by: Alex Shi <alex.shi@linaro.org>
Signed-off-by: Jens Wiklander <jens.wiklander@linaro.org>
drivers/tee/optee/core.c

index 7952357df9c862c9d9558522c3664d3d5059a572..edb6e4e9ef3acb8d18fcf9de4280e10fcbda5f14 100644 (file)
@@ -590,7 +590,6 @@ static int __init optee_driver_init(void)
                return -ENODEV;
 
        np = of_find_matching_node(fw_np, optee_match);
-       of_node_put(fw_np);
        if (!np)
                return -ENODEV;