Fix a few stylistic warnings from Apple's C compilers.

[originally from svn r2446]

diff --git a/raw.c b/raw.c
index 8e8f7e0a16021a2f34884a4708b08ee960ca4b2d..0e6c14102cdb7de39a00f1695f0076dc25b4d2a5 100644 (file)
--- a/raw.c
+++ b/raw.c
@@ -96,7 +96,7 @@ static char *raw_init(void *frontend_handle, void **backend_handle,
        sfree(buf);
     }
     addr = name_lookup(host, port, realhost);
-    if ((err = sk_addr_error(addr)))
+    if ((err = sk_addr_error(addr)) != NULL)
        return err;
 
     if (port < 0)
@@ -113,7 +113,7 @@ static char *raw_init(void *frontend_handle, void **backend_handle,
        sfree(buf);
     }
     raw->s = new_connection(addr, *realhost, port, 0, 1, nodelay, (Plug) raw);
-    if ((err = sk_socket_error(raw->s)))
+    if ((err = sk_socket_error(raw->s)) != NULL)
        return err;
 
     sk_addr_free(addr);

diff --git a/rlogin.c b/rlogin.c
index 2cc2a21744c4b0803cacd7be239260434597b67f..9c249f27f5e245706be3ed4785677a1dc6aedb81 100644 (file)
--- a/rlogin.c
+++ b/rlogin.c
@@ -127,7 +127,7 @@ static char *rlogin_init(void *frontend_handle, void **backend_handle,
        sfree(buf);
     }
     addr = name_lookup(host, port, realhost);
-    if ((err = sk_addr_error(addr)))
+    if ((err = sk_addr_error(addr)) != NULL)
        return err;
 
     if (port < 0)
@@ -145,7 +145,7 @@ static char *rlogin_init(void *frontend_handle, void **backend_handle,
     }
     rlogin->s = new_connection(addr, *realhost, port, 1, 0,
                               nodelay, (Plug) rlogin);
-    if ((err = sk_socket_error(rlogin->s)))
+    if ((err = sk_socket_error(rlogin->s)) != NULL)
        return err;
 
     sk_addr_free(addr);
@@ -164,7 +164,7 @@ static char *rlogin_init(void *frontend_handle, void **backend_handle,
        sk_write(rlogin->s, &z, 1);
        sk_write(rlogin->s, cfg.termtype, strlen(cfg.termtype));
        sk_write(rlogin->s, "/", 1);
-       for (p = cfg.termspeed; isdigit(*p); p++);
+       for (p = cfg.termspeed; isdigit(*p); p++) continue;
        sk_write(rlogin->s, cfg.termspeed, p - cfg.termspeed);
        rlogin->bufsize = sk_write(rlogin->s, &z, 1);
     }