]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
fpga: mgr: altera-ps-spi: make array dummy static, shrinks object size
authorColin Ian King <colin.king@canonical.com>
Thu, 24 Jan 2019 20:45:54 +0000 (14:45 -0600)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 31 Jan 2019 15:22:51 +0000 (16:22 +0100)
Don't populate the const array dummy on the stack but instead
make it static. Makes the object code smaller by 26 bytes:

Before:
   text    data     bss     dec     hex filename
   7371    2032       0    9403    24bb drivers/fpga/altera-ps-spi.o

After:
   text    data     bss     dec     hex filename
   7281    2096       0    9377    24a1 drivers/fpga/altera-ps-spi.o

(gcc version 8.2.0 x86_64)

Signed-off-by: Colin Ian King <colin.king@canonical.com>
Acked-by: Alan Tull <atull@kernel.org>
Acked-by: Moritz Fischer <mdf@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/fpga/altera-ps-spi.c

index 8c18beec6b572058c1dd34f95bf3350fca770c65..678d0115f840c5e1be958c3d82834061937bc35e 100644 (file)
@@ -205,7 +205,7 @@ static int altera_ps_write_complete(struct fpga_manager *mgr,
                                    struct fpga_image_info *info)
 {
        struct altera_ps_conf *conf = mgr->priv;
-       const char dummy[] = {0};
+       static const char dummy[] = {0};
        int ret;
 
        if (gpiod_get_value_cansleep(conf->status)) {