]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
staging:rtl8192u: Remove typedef and rename QOS_TCLAS - Style
authorJohn Whitmore <johnfwhitmore@gmail.com>
Sat, 4 Aug 2018 09:18:53 +0000 (10:18 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sun, 5 Aug 2018 14:22:56 +0000 (16:22 +0200)
Remove the typedef from the union QOS_TCLAS, which causes a checkpatch
issue with defining new types. In addition, as a type, the name should
be in lowercase so has been changed.

These are coding style changes and should have no impact on runtime
code execution.

Signed-off-by: John Whitmore <johnfwhitmore@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/rtl8192u/ieee80211/rtl819x_TS.h
drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c

index 5cf00a2e08ae439f4c39071a0ccf9ecd3354d47b..823ba363e0abe896fc3e44aead97f330f9d9f855 100644 (file)
@@ -14,7 +14,7 @@ enum tr_select {
        RX_DIR = 1,
 };
 
-typedef union _QOS_TCLAS {
+union qos_tclas {
 
        struct _TYPE_GENERAL {
                u8              Priority;
@@ -63,7 +63,7 @@ typedef union _QOS_TCLAS {
                u8              Mask;
                u16             TagType;
        } TYPE2_8021Q;
-} QOS_TCLAS, *PQOS_TCLAS;
+};
 
 struct ts_common_info {
        struct list_head                list;
@@ -71,7 +71,7 @@ struct ts_common_info {
        struct timer_list               inact_timer;
        u8                              addr[6];
        struct tspec_body               t_spec;
-       QOS_TCLAS                       t_class[TCLAS_NUM];
+       union qos_tclas                 t_class[TCLAS_NUM];
        u8                              t_clas_proc;
        u8                              t_clas_num;
 };
index de06cd11ab65434bd084fb9d4e2fe8c1813e8a70..d46d8f468671d0e43f8b529fafee707a40c4d81c 100644 (file)
@@ -105,7 +105,7 @@ static void ResetTsCommonInfo(struct ts_common_info *pTsCommonInfo)
 {
        eth_zero_addr(pTsCommonInfo->addr);
        memset(&pTsCommonInfo->t_spec, 0, sizeof(struct tspec_body));
-       memset(&pTsCommonInfo->t_class, 0, sizeof(QOS_TCLAS)*TCLAS_NUM);
+       memset(&pTsCommonInfo->t_class, 0, sizeof(union qos_tclas)*TCLAS_NUM);
        pTsCommonInfo->t_clas_proc = 0;
        pTsCommonInfo->t_clas_num = 0;
 }
@@ -265,7 +265,7 @@ static struct ts_common_info *SearchAdmitTRStream(struct ieee80211_device *ieee,
 }
 
 static void MakeTSEntry(struct ts_common_info *pTsCommonInfo, u8 *Addr,
-                       struct tspec_body *pTSPEC, PQOS_TCLAS pTCLAS, u8 TCLAS_Num,
+                       struct tspec_body *pTSPEC, union qos_tclas *pTCLAS, u8 TCLAS_Num,
                        u8 TCLAS_Proc)
 {
        u8      count;
@@ -279,7 +279,7 @@ static void MakeTSEntry(struct ts_common_info *pTsCommonInfo, u8 *Addr,
                memcpy((u8 *)(&(pTsCommonInfo->t_spec)), (u8 *)pTSPEC, sizeof(struct tspec_body));
 
        for(count = 0; count < TCLAS_Num; count++)
-               memcpy((u8 *)(&(pTsCommonInfo->t_class[count])), (u8 *)pTCLAS, sizeof(QOS_TCLAS));
+               memcpy((u8 *)(&(pTsCommonInfo->t_class[count])), (u8 *)pTCLAS, sizeof(union qos_tclas));
 
        pTsCommonInfo->t_clas_proc = TCLAS_Proc;
        pTsCommonInfo->t_clas_num = TCLAS_Num;