]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
alx: fix wrong condition to free descriptor memory
authorTobias Regnery <tobias.regnery@gmail.com>
Tue, 24 Jan 2017 13:34:22 +0000 (14:34 +0100)
committerDavid S. Miller <davem@davemloft.net>
Tue, 24 Jan 2017 20:27:58 +0000 (15:27 -0500)
The condition to free the descriptor memory is wrong, we want to free the
memory if it is set and not if it is unset. Invert the test to fix this
issue.

Fixes: b0999223f224b ("alx: add ability to allocate and free alx_napi structures")
Signed-off-by: Tobias Regnery <tobias.regnery@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/atheros/alx/main.c

index c8f525574d68c67cbed2899c8461ace4606a7515..765306bd78c2c872ed4a905952a9acd7460df4e6 100644 (file)
@@ -703,7 +703,7 @@ static void alx_free_rings(struct alx_priv *alx)
        if (alx->qnapi[0] && alx->qnapi[0]->rxq)
                kfree(alx->qnapi[0]->rxq->bufs);
 
-       if (!alx->descmem.virt)
+       if (alx->descmem.virt)
                dma_free_coherent(&alx->hw.pdev->dev,
                                  alx->descmem.size,
                                  alx->descmem.virt,