remoteproc: qcom: q6v5-mss: fixup q6v5_pds_enable error handling

dev_pm_domain_attach_by_name will return NULL if the requested
power-domain is not a part device node. This could result in
NULL pointer de-reference in q6v5_pds_enable. Fix this by
checking for IS_ERR_OR_NULL and forward the appropriate error
code.

Fixes: 4760a896be88e ("remoteproc: q6v5-mss: Vote for rpmh power domains")
Signed-off-by: Sibi Sankar <sibis@codeaurora.org>
Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>

diff --git a/drivers/remoteproc/qcom_q6v5_mss.c b/drivers/remoteproc/qcom_q6v5_mss.c
index 8fcf9d28dd731f0eafe80e6830b70dcc25a8b8f2..de919f2e8b949c3184586c7ac7450a7d3e101a08 100644 (file)
--- a/drivers/remoteproc/qcom_q6v5_mss.c
+++ b/drivers/remoteproc/qcom_q6v5_mss.c
@@ -1282,8 +1282,8 @@ static int q6v5_pds_attach(struct device *dev, struct device **devs,
 
        for (i = 0; i < num_pds; i++) {
                devs[i] = dev_pm_domain_attach_by_name(dev, pd_names[i]);
-               if (IS_ERR(devs[i])) {
-                       ret = PTR_ERR(devs[i]);
+               if (IS_ERR_OR_NULL(devs[i])) {
+                       ret = PTR_ERR(devs[i]) ? : -ENODATA;
                        goto unroll_attach;
                }
        }