]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
crypto: cavium - Register the CNN55XX supported crypto algorithms.
authorSrikanth Jampala <Jampala.Srikanth@cavium.com>
Tue, 30 May 2017 11:58:03 +0000 (17:28 +0530)
committerHerbert Xu <herbert@gondor.apana.org.au>
Sat, 10 Jun 2017 04:04:34 +0000 (12:04 +0800)
Register the Symmetric crypto algorithms supported by
CNN55XX driver with crypto subsystem.

The following Symmetric crypto algorithms are supported,
  - aes with cbc, ecb, cfb, xts, ctr and cts modes
  - des3_ede with cbc and ecb modes

Signed-off-by: Srikanth Jampala <Jampala.Srikanth@cavium.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
drivers/crypto/cavium/nitrox/Makefile
drivers/crypto/cavium/nitrox/nitrox_algs.c [new file with mode: 0644]
drivers/crypto/cavium/nitrox/nitrox_common.h
drivers/crypto/cavium/nitrox/nitrox_lib.c
drivers/crypto/cavium/nitrox/nitrox_main.c

index ef457f609d88862e32c8b2619af9771e21510238..5af2e4368267f70d0403068b22e07368a0e30842 100644 (file)
@@ -4,4 +4,5 @@ n5pf-objs := nitrox_main.o \
        nitrox_isr.o \
        nitrox_lib.o \
        nitrox_hal.o \
-       nitrox_reqmgr.o
+       nitrox_reqmgr.o \
+       nitrox_algs.o
diff --git a/drivers/crypto/cavium/nitrox/nitrox_algs.c b/drivers/crypto/cavium/nitrox/nitrox_algs.c
new file mode 100644 (file)
index 0000000..ce33027
--- /dev/null
@@ -0,0 +1,457 @@
+#include <linux/crypto.h>
+#include <linux/kernel.h>
+#include <linux/module.h>
+#include <linux/printk.h>
+
+#include <crypto/aes.h>
+#include <crypto/skcipher.h>
+#include <crypto/ctr.h>
+#include <crypto/des.h>
+#include <crypto/xts.h>
+
+#include "nitrox_dev.h"
+#include "nitrox_common.h"
+#include "nitrox_req.h"
+
+#define PRIO 4001
+
+struct nitrox_cipher {
+       const char *name;
+       enum flexi_cipher value;
+};
+
+/**
+ * supported cipher list
+ */
+static const struct nitrox_cipher flexi_cipher_table[] = {
+       { "null",               CIPHER_NULL },
+       { "cbc(des3_ede)",      CIPHER_3DES_CBC },
+       { "ecb(des3_ede)",      CIPHER_3DES_ECB },
+       { "cbc(aes)",           CIPHER_AES_CBC },
+       { "ecb(aes)",           CIPHER_AES_ECB },
+       { "cfb(aes)",           CIPHER_AES_CFB },
+       { "rfc3686(ctr(aes))",  CIPHER_AES_CTR },
+       { "xts(aes)",           CIPHER_AES_XTS },
+       { "cts(cbc(aes))",      CIPHER_AES_CBC_CTS },
+       { NULL,                 CIPHER_INVALID }
+};
+
+static enum flexi_cipher flexi_cipher_type(const char *name)
+{
+       const struct nitrox_cipher *cipher = flexi_cipher_table;
+
+       while (cipher->name) {
+               if (!strcmp(cipher->name, name))
+                       break;
+               cipher++;
+       }
+       return cipher->value;
+}
+
+static int flexi_aes_keylen(int keylen)
+{
+       int aes_keylen;
+
+       switch (keylen) {
+       case AES_KEYSIZE_128:
+               aes_keylen = 1;
+               break;
+       case AES_KEYSIZE_192:
+               aes_keylen = 2;
+               break;
+       case AES_KEYSIZE_256:
+               aes_keylen = 3;
+               break;
+       default:
+               aes_keylen = -EINVAL;
+               break;
+       }
+       return aes_keylen;
+}
+
+static int nitrox_skcipher_init(struct crypto_skcipher *tfm)
+{
+       struct nitrox_crypto_ctx *nctx = crypto_skcipher_ctx(tfm);
+       void *fctx;
+
+       /* get the first device */
+       nctx->ndev = nitrox_get_first_device();
+       if (!nctx->ndev)
+               return -ENODEV;
+
+       /* allocate nitrox crypto context */
+       fctx = crypto_alloc_context(nctx->ndev);
+       if (!fctx) {
+               nitrox_put_device(nctx->ndev);
+               return -ENOMEM;
+       }
+       nctx->u.ctx_handle = (uintptr_t)fctx;
+       crypto_skcipher_set_reqsize(tfm, crypto_skcipher_reqsize(tfm) +
+                                   sizeof(struct nitrox_kcrypt_request));
+       return 0;
+}
+
+static void nitrox_skcipher_exit(struct crypto_skcipher *tfm)
+{
+       struct nitrox_crypto_ctx *nctx = crypto_skcipher_ctx(tfm);
+
+       /* free the nitrox crypto context */
+       if (nctx->u.ctx_handle) {
+               struct flexi_crypto_context *fctx = nctx->u.fctx;
+
+               memset(&fctx->crypto, 0, sizeof(struct crypto_keys));
+               memset(&fctx->auth, 0, sizeof(struct auth_keys));
+               crypto_free_context((void *)fctx);
+       }
+       nitrox_put_device(nctx->ndev);
+
+       nctx->u.ctx_handle = 0;
+       nctx->ndev = NULL;
+}
+
+static inline int nitrox_skcipher_setkey(struct crypto_skcipher *cipher,
+                                        int aes_keylen, const u8 *key,
+                                        unsigned int keylen)
+{
+       struct crypto_tfm *tfm = crypto_skcipher_tfm(cipher);
+       struct nitrox_crypto_ctx *nctx = crypto_tfm_ctx(tfm);
+       struct flexi_crypto_context *fctx;
+       enum flexi_cipher cipher_type;
+       const char *name;
+
+       name = crypto_tfm_alg_name(tfm);
+       cipher_type = flexi_cipher_type(name);
+       if (unlikely(cipher_type == CIPHER_INVALID)) {
+               pr_err("unsupported cipher: %s\n", name);
+               return -EINVAL;
+       }
+
+       /* fill crypto context */
+       fctx = nctx->u.fctx;
+       fctx->flags = 0;
+       fctx->w0.cipher_type = cipher_type;
+       fctx->w0.aes_keylen = aes_keylen;
+       fctx->w0.iv_source = IV_FROM_DPTR;
+       fctx->flags = cpu_to_be64(*(u64 *)&fctx->w0);
+       /* copy the key to context */
+       memcpy(fctx->crypto.u.key, key, keylen);
+
+       return 0;
+}
+
+static int nitrox_aes_setkey(struct crypto_skcipher *cipher, const u8 *key,
+                            unsigned int keylen)
+{
+       int aes_keylen;
+
+       aes_keylen = flexi_aes_keylen(keylen);
+       if (aes_keylen < 0) {
+               crypto_skcipher_set_flags(cipher, CRYPTO_TFM_RES_BAD_KEY_LEN);
+               return -EINVAL;
+       }
+       return nitrox_skcipher_setkey(cipher, aes_keylen, key, keylen);
+}
+
+static void nitrox_skcipher_callback(struct skcipher_request *skreq,
+                                    int err)
+{
+       if (err) {
+               pr_err_ratelimited("request failed status 0x%0x\n", err);
+               err = -EINVAL;
+       }
+       skcipher_request_complete(skreq, err);
+}
+
+static int nitrox_skcipher_crypt(struct skcipher_request *skreq, bool enc)
+{
+       struct crypto_skcipher *cipher = crypto_skcipher_reqtfm(skreq);
+       struct nitrox_crypto_ctx *nctx = crypto_skcipher_ctx(cipher);
+       struct nitrox_kcrypt_request *nkreq = skcipher_request_ctx(skreq);
+       int ivsize = crypto_skcipher_ivsize(cipher);
+       struct se_crypto_request *creq;
+
+       creq = &nkreq->creq;
+       creq->flags = skreq->base.flags;
+       creq->gfp = (skreq->base.flags & CRYPTO_TFM_REQ_MAY_SLEEP) ?
+                    GFP_KERNEL : GFP_ATOMIC;
+
+       /* fill the request */
+       creq->ctrl.value = 0;
+       creq->opcode = FLEXI_CRYPTO_ENCRYPT_HMAC;
+       creq->ctrl.s.arg = (enc ? ENCRYPT : DECRYPT);
+       /* param0: length of the data to be encrypted */
+       creq->gph.param0 = cpu_to_be16(skreq->cryptlen);
+       creq->gph.param1 = 0;
+       /* param2: encryption data offset */
+       creq->gph.param2 = cpu_to_be16(ivsize);
+       creq->gph.param3 = 0;
+
+       creq->ctx_handle = nctx->u.ctx_handle;
+       creq->ctrl.s.ctxl = sizeof(struct flexi_crypto_context);
+
+       /* copy the iv */
+       memcpy(creq->iv, skreq->iv, ivsize);
+       creq->ivsize = ivsize;
+       creq->src = skreq->src;
+       creq->dst = skreq->dst;
+
+       nkreq->nctx = nctx;
+       nkreq->skreq = skreq;
+
+       /* send the crypto request */
+       return nitrox_process_se_request(nctx->ndev, creq,
+                                        nitrox_skcipher_callback, skreq);
+}
+
+static int nitrox_aes_encrypt(struct skcipher_request *skreq)
+{
+       return nitrox_skcipher_crypt(skreq, true);
+}
+
+static int nitrox_aes_decrypt(struct skcipher_request *skreq)
+{
+       return nitrox_skcipher_crypt(skreq, false);
+}
+
+static int nitrox_3des_setkey(struct crypto_skcipher *cipher,
+                             const u8 *key, unsigned int keylen)
+{
+       if (keylen != DES3_EDE_KEY_SIZE) {
+               crypto_skcipher_set_flags(cipher, CRYPTO_TFM_RES_BAD_KEY_LEN);
+               return -EINVAL;
+       }
+
+       return nitrox_skcipher_setkey(cipher, 0, key, keylen);
+}
+
+static int nitrox_3des_encrypt(struct skcipher_request *skreq)
+{
+       return nitrox_skcipher_crypt(skreq, true);
+}
+
+static int nitrox_3des_decrypt(struct skcipher_request *skreq)
+{
+       return nitrox_skcipher_crypt(skreq, false);
+}
+
+static int nitrox_aes_xts_setkey(struct crypto_skcipher *cipher,
+                                const u8 *key, unsigned int keylen)
+{
+       struct crypto_tfm *tfm = crypto_skcipher_tfm(cipher);
+       struct nitrox_crypto_ctx *nctx = crypto_tfm_ctx(tfm);
+       struct flexi_crypto_context *fctx;
+       int aes_keylen, ret;
+
+       ret = xts_check_key(tfm, key, keylen);
+       if (ret)
+               return ret;
+
+       keylen /= 2;
+
+       aes_keylen = flexi_aes_keylen(keylen);
+       if (aes_keylen < 0) {
+               crypto_skcipher_set_flags(cipher, CRYPTO_TFM_RES_BAD_KEY_LEN);
+               return -EINVAL;
+       }
+
+       fctx = nctx->u.fctx;
+       /* copy KEY2 */
+       memcpy(fctx->auth.u.key2, (key + keylen), keylen);
+
+       return nitrox_skcipher_setkey(cipher, aes_keylen, key, keylen);
+}
+
+static int nitrox_aes_ctr_rfc3686_setkey(struct crypto_skcipher *cipher,
+                                        const u8 *key, unsigned int keylen)
+{
+       struct crypto_tfm *tfm = crypto_skcipher_tfm(cipher);
+       struct nitrox_crypto_ctx *nctx = crypto_tfm_ctx(tfm);
+       struct flexi_crypto_context *fctx;
+       int aes_keylen;
+
+       if (keylen < CTR_RFC3686_NONCE_SIZE)
+               return -EINVAL;
+
+       fctx = nctx->u.fctx;
+
+       memcpy(fctx->crypto.iv, key + (keylen - CTR_RFC3686_NONCE_SIZE),
+              CTR_RFC3686_NONCE_SIZE);
+
+       keylen -= CTR_RFC3686_NONCE_SIZE;
+
+       aes_keylen = flexi_aes_keylen(keylen);
+       if (aes_keylen < 0) {
+               crypto_skcipher_set_flags(cipher, CRYPTO_TFM_RES_BAD_KEY_LEN);
+               return -EINVAL;
+       }
+       return nitrox_skcipher_setkey(cipher, aes_keylen, key, keylen);
+}
+
+static struct skcipher_alg nitrox_skciphers[] = { {
+       .base = {
+               .cra_name = "cbc(aes)",
+               .cra_driver_name = "n5_cbc(aes)",
+               .cra_priority = PRIO,
+               .cra_flags = CRYPTO_ALG_ASYNC,
+               .cra_blocksize = AES_BLOCK_SIZE,
+               .cra_ctxsize = sizeof(struct nitrox_crypto_ctx),
+               .cra_alignmask = 0,
+               .cra_module = THIS_MODULE,
+       },
+       .min_keysize = AES_MIN_KEY_SIZE,
+       .max_keysize = AES_MAX_KEY_SIZE,
+       .ivsize = AES_BLOCK_SIZE,
+       .setkey = nitrox_aes_setkey,
+       .encrypt = nitrox_aes_encrypt,
+       .decrypt = nitrox_aes_decrypt,
+       .init = nitrox_skcipher_init,
+       .exit = nitrox_skcipher_exit,
+}, {
+       .base = {
+               .cra_name = "ecb(aes)",
+               .cra_driver_name = "n5_ecb(aes)",
+               .cra_priority = PRIO,
+               .cra_flags = CRYPTO_ALG_ASYNC,
+               .cra_blocksize = AES_BLOCK_SIZE,
+               .cra_ctxsize = sizeof(struct nitrox_crypto_ctx),
+               .cra_alignmask = 0,
+               .cra_module = THIS_MODULE,
+       },
+       .min_keysize = AES_MIN_KEY_SIZE,
+       .max_keysize = AES_MAX_KEY_SIZE,
+       .ivsize = AES_BLOCK_SIZE,
+       .setkey = nitrox_aes_setkey,
+       .encrypt = nitrox_aes_encrypt,
+       .decrypt = nitrox_aes_decrypt,
+       .init = nitrox_skcipher_init,
+       .exit = nitrox_skcipher_exit,
+}, {
+       .base = {
+               .cra_name = "cfb(aes)",
+               .cra_driver_name = "n5_cfb(aes)",
+               .cra_priority = PRIO,
+               .cra_flags = CRYPTO_ALG_ASYNC,
+               .cra_blocksize = AES_BLOCK_SIZE,
+               .cra_ctxsize = sizeof(struct nitrox_crypto_ctx),
+               .cra_alignmask = 0,
+               .cra_module = THIS_MODULE,
+       },
+       .min_keysize = AES_MIN_KEY_SIZE,
+       .max_keysize = AES_MAX_KEY_SIZE,
+       .ivsize = AES_BLOCK_SIZE,
+       .setkey = nitrox_aes_setkey,
+       .encrypt = nitrox_aes_encrypt,
+       .decrypt = nitrox_aes_decrypt,
+       .init = nitrox_skcipher_init,
+       .exit = nitrox_skcipher_exit,
+}, {
+       .base = {
+               .cra_name = "xts(aes)",
+               .cra_driver_name = "n5_xts(aes)",
+               .cra_priority = PRIO,
+               .cra_flags = CRYPTO_ALG_ASYNC,
+               .cra_blocksize = AES_BLOCK_SIZE,
+               .cra_ctxsize = sizeof(struct nitrox_crypto_ctx),
+               .cra_alignmask = 0,
+               .cra_module = THIS_MODULE,
+       },
+       .min_keysize = 2 * AES_MIN_KEY_SIZE,
+       .max_keysize = 2 * AES_MAX_KEY_SIZE,
+       .ivsize = AES_BLOCK_SIZE,
+       .setkey = nitrox_aes_xts_setkey,
+       .encrypt = nitrox_aes_encrypt,
+       .decrypt = nitrox_aes_decrypt,
+       .init = nitrox_skcipher_init,
+       .exit = nitrox_skcipher_exit,
+}, {
+       .base = {
+               .cra_name = "rfc3686(ctr(aes))",
+               .cra_driver_name = "n5_rfc3686(ctr(aes))",
+               .cra_priority = PRIO,
+               .cra_flags = CRYPTO_ALG_ASYNC,
+               .cra_blocksize = 1,
+               .cra_ctxsize = sizeof(struct nitrox_crypto_ctx),
+               .cra_alignmask = 0,
+               .cra_module = THIS_MODULE,
+       },
+       .min_keysize = AES_MIN_KEY_SIZE + CTR_RFC3686_NONCE_SIZE,
+       .max_keysize = AES_MAX_KEY_SIZE + CTR_RFC3686_NONCE_SIZE,
+       .ivsize = CTR_RFC3686_IV_SIZE,
+       .init = nitrox_skcipher_init,
+       .exit = nitrox_skcipher_exit,
+       .setkey = nitrox_aes_ctr_rfc3686_setkey,
+       .encrypt = nitrox_aes_encrypt,
+       .decrypt = nitrox_aes_decrypt,
+}, {
+       .base = {
+               .cra_name = "cts(cbc(aes))",
+               .cra_driver_name = "n5_cts(cbc(aes))",
+               .cra_priority = PRIO,
+               .cra_flags = CRYPTO_ALG_ASYNC,
+               .cra_blocksize = AES_BLOCK_SIZE,
+               .cra_ctxsize = sizeof(struct nitrox_crypto_ctx),
+               .cra_alignmask = 0,
+               .cra_type = &crypto_ablkcipher_type,
+               .cra_module = THIS_MODULE,
+       },
+       .min_keysize = AES_MIN_KEY_SIZE,
+       .max_keysize = AES_MAX_KEY_SIZE,
+       .ivsize = AES_BLOCK_SIZE,
+       .setkey = nitrox_aes_setkey,
+       .encrypt = nitrox_aes_encrypt,
+       .decrypt = nitrox_aes_decrypt,
+       .init = nitrox_skcipher_init,
+       .exit = nitrox_skcipher_exit,
+}, {
+       .base = {
+               .cra_name = "cbc(des3_ede)",
+               .cra_driver_name = "n5_cbc(des3_ede)",
+               .cra_priority = PRIO,
+               .cra_flags = CRYPTO_ALG_ASYNC,
+               .cra_blocksize = DES3_EDE_BLOCK_SIZE,
+               .cra_ctxsize = sizeof(struct nitrox_crypto_ctx),
+               .cra_alignmask = 0,
+               .cra_module = THIS_MODULE,
+       },
+       .min_keysize = DES3_EDE_KEY_SIZE,
+       .max_keysize = DES3_EDE_KEY_SIZE,
+       .ivsize = DES3_EDE_BLOCK_SIZE,
+       .setkey = nitrox_3des_setkey,
+       .encrypt = nitrox_3des_encrypt,
+       .decrypt = nitrox_3des_decrypt,
+       .init = nitrox_skcipher_init,
+       .exit = nitrox_skcipher_exit,
+}, {
+       .base = {
+               .cra_name = "ecb(des3_ede)",
+               .cra_driver_name = "n5_ecb(des3_ede)",
+               .cra_priority = PRIO,
+               .cra_flags = CRYPTO_ALG_ASYNC,
+               .cra_blocksize = DES3_EDE_BLOCK_SIZE,
+               .cra_ctxsize = sizeof(struct nitrox_crypto_ctx),
+               .cra_alignmask = 0,
+               .cra_module = THIS_MODULE,
+       },
+       .min_keysize = DES3_EDE_KEY_SIZE,
+       .max_keysize = DES3_EDE_KEY_SIZE,
+       .ivsize = DES3_EDE_BLOCK_SIZE,
+       .setkey = nitrox_3des_setkey,
+       .encrypt = nitrox_3des_encrypt,
+       .decrypt = nitrox_3des_decrypt,
+       .init = nitrox_skcipher_init,
+       .exit = nitrox_skcipher_exit,
+}
+
+};
+
+int nitrox_crypto_register(void)
+{
+       return crypto_register_skciphers(nitrox_skciphers,
+                                        ARRAY_SIZE(nitrox_skciphers));
+}
+
+void nitrox_crypto_unregister(void)
+{
+       crypto_unregister_skciphers(nitrox_skciphers,
+                                   ARRAY_SIZE(nitrox_skciphers));
+}
index 3284ffe4837a0627b76d191f2a135356f0b6c043..4888c7823a5fb07cf999e06ed1d6a03765c30f08 100644 (file)
@@ -4,6 +4,13 @@
 #include "nitrox_dev.h"
 #include "nitrox_req.h"
 
+int nitrox_crypto_register(void);
+void nitrox_crypto_unregister(void);
+void *crypto_alloc_context(struct nitrox_device *ndev);
+void crypto_free_context(void *ctx);
+struct nitrox_device *nitrox_get_first_device(void);
+void nitrox_put_device(struct nitrox_device *ndev);
+
 void nitrox_pf_cleanup_isr(struct nitrox_device *ndev);
 int nitrox_pf_init_isr(struct nitrox_device *ndev);
 
index 846e990d4f35edf552dd104414b93c1d9d3daae5..b4a391adb9b676a7b3ef5a33f858797c605c1e5f 100644 (file)
@@ -137,6 +137,44 @@ static void destroy_crypto_dma_pool(struct nitrox_device *ndev)
        ndev->ctx_pool = NULL;
 }
 
+/*
+ * crypto_alloc_context - Allocate crypto context from pool
+ * @ndev: NITROX Device
+ */
+void *crypto_alloc_context(struct nitrox_device *ndev)
+{
+       struct ctx_hdr *ctx;
+       void *vaddr;
+       dma_addr_t dma;
+
+       vaddr = dma_pool_alloc(ndev->ctx_pool, (GFP_ATOMIC | __GFP_ZERO), &dma);
+       if (!vaddr)
+               return NULL;
+
+       /* fill meta data */
+       ctx = vaddr;
+       ctx->pool = ndev->ctx_pool;
+       ctx->dma = dma;
+       ctx->ctx_dma = dma + sizeof(struct ctx_hdr);
+
+       return ((u8 *)vaddr + sizeof(struct ctx_hdr));
+}
+
+/**
+ * crypto_free_context - Free crypto context to pool
+ * @ctx: context to free
+ */
+void crypto_free_context(void *ctx)
+{
+       struct ctx_hdr *ctxp;
+
+       if (!ctx)
+               return;
+
+       ctxp = (struct ctx_hdr *)((u8 *)ctx - sizeof(struct ctx_hdr));
+       dma_pool_free(ctxp->pool, ctxp, ctxp->dma);
+}
+
 /**
  * nitrox_common_sw_init - allocate software resources.
  * @ndev: NITROX device
index 9b07003e39f7c44dd2f8df6c8298fbc946a968f5..eee6fb501580b726ef7267143bb777364654215b 100644 (file)
@@ -180,6 +180,35 @@ static void nitrox_remove_from_devlist(struct nitrox_device *ndev)
        mutex_unlock(&devlist_lock);
 }
 
+struct nitrox_device *nitrox_get_first_device(void)
+{
+       struct nitrox_device *ndev = NULL;
+
+       mutex_lock(&devlist_lock);
+       list_for_each_entry(ndev, &ndevlist, list) {
+               if (nitrox_ready(ndev))
+                       break;
+       }
+       mutex_unlock(&devlist_lock);
+       if (!ndev)
+               return NULL;
+
+       refcount_inc(&ndev->refcnt);
+       /* barrier to sync with other cpus */
+       smp_mb__after_atomic();
+       return ndev;
+}
+
+void nitrox_put_device(struct nitrox_device *ndev)
+{
+       if (!ndev)
+               return;
+
+       refcount_dec(&ndev->refcnt);
+       /* barrier to sync with other cpus */
+       smp_mb__after_atomic();
+}
+
 static int nitrox_reset_device(struct pci_dev *pdev)
 {
        int pos = 0;
@@ -526,8 +555,18 @@ static int nitrox_probe(struct pci_dev *pdev,
        set_bit(NITROX_READY, &ndev->status);
        /* barrier to sync with other cpus */
        smp_mb__after_atomic();
+
+       err = nitrox_crypto_register();
+       if (err)
+               goto crypto_fail;
+
        return 0;
 
+crypto_fail:
+       nitrox_debugfs_exit(ndev);
+       clear_bit(NITROX_READY, &ndev->status);
+       /* barrier to sync with other cpus */
+       smp_mb__after_atomic();
 pf_hw_fail:
        nitrox_pf_sw_cleanup(ndev);
 ioremap_err:
@@ -565,6 +604,7 @@ static void nitrox_remove(struct pci_dev *pdev)
        smp_mb__after_atomic();
 
        nitrox_remove_from_devlist(ndev);
+       nitrox_crypto_unregister();
        nitrox_debugfs_exit(ndev);
        nitrox_pf_sw_cleanup(ndev);