eeprom: idt_89hpesx: Drop kfree for memory allocated with devm_kzalloc

It's not necessary to free memory allocated with devm_kzalloc
and using kfree leads to a double free.

Fixes: cfad6425382e ("eeprom: Add IDT 89HPESx EEPROM/CSR driver")
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Serge Semin <fancer.lancer@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

diff --git a/drivers/misc/eeprom/idt_89hpesx.c b/drivers/misc/eeprom/idt_89hpesx.c
index 5d48aecbe2082cdcb0935844d15a7f43489f1578..4a22a1d99395b4ec806b430e44957f2d85bac38e 100644 (file)
--- a/drivers/misc/eeprom/idt_89hpesx.c
+++ b/drivers/misc/eeprom/idt_89hpesx.c
@@ -1358,7 +1358,6 @@ static int idt_create_sysfs_files(struct idt_89hpesx_dev *pdev)
        pdev->ee_file->size = pdev->eesize;
        ret = sysfs_create_bin_file(&dev->kobj, pdev->ee_file);
        if (ret != 0) {
-               kfree(pdev->ee_file);
                dev_err(dev, "Failed to create EEPROM sysfs-node");
                return ret;
        }
@@ -1380,9 +1379,6 @@ static void idt_remove_sysfs_files(struct idt_89hpesx_dev *pdev)
 
        /* Remove EEPROM sysfs file */
        sysfs_remove_bin_file(&dev->kobj, pdev->ee_file);
-
-       /* Free memory allocated for bin_attribute structure */
-       kfree(pdev->ee_file);
 }
 
 /*