]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
video: fbdev: Fix potential NULL pointer dereference
authorYueHaibing <yuehaibing@huawei.com>
Fri, 8 Feb 2019 18:24:49 +0000 (19:24 +0100)
committerBartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Fri, 8 Feb 2019 18:24:49 +0000 (19:24 +0100)
There is a potential NULL pointer dereference in case
fb_create_modedb() fails and returns NULL.

Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Cc: Kees Cook <keescook@chromium.org>
Cc: Rob Herring <robh@kernel.org>
Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
drivers/video/fbdev/core/fbmon.c

index dd3128990776ef35670fbc4e3cab09bbf6b10ebe..3558a70a66640afea5d1259bb7b582b0ba0c5891 100644 (file)
@@ -978,6 +978,8 @@ void fb_edid_to_monspecs(unsigned char *edid, struct fb_monspecs *specs)
        get_monspecs(edid, specs);
 
        specs->modedb = fb_create_modedb(edid, &specs->modedb_len, specs);
+       if (!specs->modedb)
+               return;
 
        /*
         * Workaround for buggy EDIDs that sets that the first