]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
powerpc/mm/hash: Remove unnecessary do { } while(0) loop
authorAneesh Kumar K.V <aneesh.kumar@linux.ibm.com>
Thu, 9 Aug 2018 13:36:42 +0000 (19:06 +0530)
committerMichael Ellerman <mpe@ellerman.id.au>
Fri, 10 Aug 2018 12:25:57 +0000 (22:25 +1000)
Avoid coverity false warnings like:

  *** CID 187347:  Control flow issues  (UNREACHABLE)
  /arch/powerpc/mm/hash_native_64.c: 819 in native_flush_hash_range()
  813        slot += hidx & _PTEIDX_GROUP_IX;
  814        hptep = htab_address + slot;
  815        want_v = hpte_encode_avpn(vpn, psize, ssize);
  816        hpte_v = hpte_get_old_v(hptep);
  817
  818        if (!HPTE_V_COMPARE(hpte_v, want_v) || !(hpte_v & HPTE_V_VALID))
  >>>     CID 187347:  Control flow issues  (UNREACHABLE)

Signed-off-by: Aneesh Kumar K.V <aneesh.kumar@linux.ibm.com>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
arch/powerpc/include/asm/book3s/64/hash-64k.h

index c81793d47af9a830bdfa6450f9135c53263dc6e9..f82ee8a3b561718c4a138b392fe6bfeb2990aea4 100644 (file)
@@ -137,10 +137,9 @@ extern bool __rpte_sub_valid(real_pte_t rpte, unsigned long index);
                shift = mmu_psize_defs[psize].shift;                    \
                for (index = 0; vpn < __end; index++,                   \
                             vpn += (1L << (shift - VPN_SHIFT))) {      \
-                       if (!__split || __rpte_sub_valid(rpte, index))  \
-                               do {
+               if (!__split || __rpte_sub_valid(rpte, index))
 
-#define pte_iterate_hashed_end() } while(0); } } while(0)
+#define pte_iterate_hashed_end()  } } while(0)
 
 #define pte_pagesize_index(mm, addr, pte)      \
        (((pte) & H_PAGE_COMBO)? MMU_PAGE_4K: MMU_PAGE_64K)