"possible unintended assignment"? I think not.

[originally from svn r2468]

diff --git a/x11fwd.c b/x11fwd.c
index decb25961d7a0fa50af52b4937dfe2305e7be04c..d21441b94bf86547bba2fefd6558d05196f5c33d 100644 (file)
--- a/x11fwd.c
+++ b/x11fwd.c
@@ -204,7 +204,7 @@ char *x11_init(Socket * s, char *display, void *c, void *auth)
      * Try to find host.
      */
     addr = name_lookup(host, port, &dummy_realhost);
-    if ((err = sk_addr_error(addr)))
+    if ((err = sk_addr_error(addr)) != NULL)
        return err;
 
     port = 6000 + displaynum;
@@ -222,7 +222,7 @@ char *x11_init(Socket * s, char *display, void *c, void *auth)
     pr->c = c;
 
     pr->s = *s = new_connection(addr, dummy_realhost, port, 0, 1, 0, (Plug) pr);
-    if ((err = sk_socket_error(*s))) {
+    if ((err = sk_socket_error(*s)) != NULL) {
        sfree(pr);
        return err;
     }