]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
dmaengine: stm32-dma: use platform_get_irq()
authorFabien Dessenne <fabien.dessenne@st.com>
Wed, 24 Apr 2019 09:21:25 +0000 (11:21 +0200)
committerVinod Koul <vkoul@kernel.org>
Fri, 26 Apr 2019 17:03:34 +0000 (22:33 +0530)
platform_get_resource(pdev, IORESOURCE_IRQ) is not recommended for
requesting IRQ's resources, as they can be not ready yet. Using
platform_get_irq() instead is preferred for getting IRQ even if it was
not retrieved earlier.

Signed-off-by: Fabien Dessenne <fabien.dessenne@st.com>
Reviewed-by: Pierre-Yves MORDRET <pierre-yves.mordret@st.com>
Signed-off-by: Vinod Koul <vkoul@kernel.org>
drivers/dma/stm32-dma.c

index ba239b529fa9e727fb58c64a2f8989fff3d31b4b..33068185c0fe67cf55c5cf20b183f0f938120829 100644 (file)
@@ -1302,13 +1302,14 @@ static int stm32_dma_probe(struct platform_device *pdev)
 
        for (i = 0; i < STM32_DMA_MAX_CHANNELS; i++) {
                chan = &dmadev->chan[i];
-               res = platform_get_resource(pdev, IORESOURCE_IRQ, i);
-               if (!res) {
-                       ret = -EINVAL;
-                       dev_err(&pdev->dev, "No irq resource for chan %d\n", i);
+               chan->irq = platform_get_irq(pdev, i);
+               if (chan->irq < 0)  {
+                       ret = chan->irq;
+                       if (ret != -EPROBE_DEFER)
+                               dev_err(&pdev->dev,
+                                       "No irq resource for chan %d\n", i);
                        goto err_unregister;
                }
-               chan->irq = res->start;
                ret = devm_request_irq(&pdev->dev, chan->irq,
                                       stm32_dma_chan_irq, 0,
                                       dev_name(chan2dev(chan)), chan);