]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
scsi: hisi_sas: fix internal abort slot timeout bug
authorXiang Chen <chenxiang66@hisilicon.com>
Tue, 24 Oct 2017 15:51:32 +0000 (23:51 +0800)
committerMartin K. Petersen <martin.petersen@oracle.com>
Wed, 25 Oct 2017 12:21:04 +0000 (08:21 -0400)
When an internal abort times out in hisi_sas_internal_task_abort(),
goto the exit label in and not go through the other task status
checks.

Signed-off-by: Xiang Chen <chenxiang66@hisilicon.com>
Signed-off-by: John Garry <john.garry@huawei.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/hisi_sas/hisi_sas_main.c

index 9e2990268f00ac741cad51a22561ca44205374b3..0eb9174f79a81408e9977ee557a1c9735c9d8bb3 100644 (file)
@@ -1469,6 +1469,7 @@ hisi_sas_internal_task_abort(struct hisi_hba *hisi_hba,
                        if (slot)
                                slot->task = NULL;
                        dev_err(dev, "internal task abort: timeout.\n");
+                       goto exit;
                }
        }