]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
samples/bpf: fix XDP_FLAGS_SKB_MODE detach for xdp_tx_iptunnel
authorJesper Dangaard Brouer <brouer@redhat.com>
Mon, 1 May 2017 09:26:20 +0000 (11:26 +0200)
committerDavid S. Miller <davem@davemloft.net>
Mon, 1 May 2017 14:42:37 +0000 (10:42 -0400)
The xdp_tx_iptunnel program can be terminated in two ways, after
N-seconds or via Ctrl-C SIGINT.  The SIGINT code path does not
handle detatching the correct XDP program, in-case the program
was attached with XDP_FLAGS_SKB_MODE.

Fix this by storing the XDP flags as a global variable, which is
available for the SIGINT handler function.

Fixes: 3993f2cb983b ("samples/bpf: Add support for SKB_MODE to xdp1 and xdp_tx_iptunnel")
Signed-off-by: Jesper Dangaard Brouer <brouer@redhat.com>
Acked-by: Daniel Borkmann <daniel@iogearbox.net>
Reviewed-by: Andy Gospodarek <andy@greyhouse.net>
Signed-off-by: David S. Miller <davem@davemloft.net>
samples/bpf/xdp_tx_iptunnel_user.c

index 880dd4aebfa4df01e0caea689afd319f48150995..92b8bde9337c8cec6128e73d23d307b628ba5a38 100644 (file)
 #define STATS_INTERVAL_S 2U
 
 static int ifindex = -1;
+static __u32 xdp_flags = 0;
 
 static void int_exit(int sig)
 {
        if (ifindex > -1)
-               set_link_xdp_fd(ifindex, -1, 0);
+               set_link_xdp_fd(ifindex, -1, xdp_flags);
        exit(0);
 }
 
@@ -142,7 +143,6 @@ int main(int argc, char **argv)
        struct iptnl_info tnl = {};
        struct rlimit r = {RLIM_INFINITY, RLIM_INFINITY};
        struct vip vip = {};
-       __u32 xdp_flags = 0;
        char filename[256];
        int opt;
        int i;