]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
Staging: rtl8192u: Replace memset with eth_broadcast_addr
authorBhumika Goyal <bhumirks@gmail.com>
Tue, 1 Mar 2016 18:48:31 +0000 (00:18 +0530)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 12 Mar 2016 06:09:09 +0000 (22:09 -0800)
Use eth_broadcast_addr to assign the broadcast address to the given
address array instead of memset when the second argument is a broacast
address 0xff. ETH_ALEN is a macro with value 6, so 6 is treated as
ETH_ALEN if it is the third argument of memset.

Done using coccinelle.
@@
expression e;
@@
- memset(e,\(0xff\|0xFF\|255\),\(ETH_ALEN\|6\));
+ eth_broadcast_addr(e);

Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c

index f8041f9d61c81ccf31a0ad2ba2c4584d482cf797..2fbbf35c40ac24ae40229f5039038615d10f4b6e 100644 (file)
@@ -342,9 +342,9 @@ inline struct sk_buff *ieee80211_probe_req(struct ieee80211_device *ieee)
        req->header.frame_ctl = cpu_to_le16(IEEE80211_STYPE_PROBE_REQ);
        req->header.duration_id = 0; /* FIXME: is this OK? */
 
-       memset(req->header.addr1, 0xff, ETH_ALEN);
+       eth_broadcast_addr(req->header.addr1);
        memcpy(req->header.addr2, ieee->dev->dev_addr, ETH_ALEN);
-       memset(req->header.addr3, 0xff, ETH_ALEN);
+       eth_broadcast_addr(req->header.addr3);
 
        tag = (u8 *) skb_put(skb,len+2+rate_len);