]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
drm/etnaviv: NULL vs IS_ERR() buf in etnaviv_core_dump()
authorDan Carpenter <dan.carpenter@oracle.com>
Mon, 14 Jan 2019 10:49:46 +0000 (13:49 +0300)
committerLucas Stach <l.stach@pengutronix.de>
Wed, 16 Jan 2019 15:29:12 +0000 (16:29 +0100)
The etnaviv_gem_get_pages() never returns NULL.  It returns error
pointers on error.

Fixes: a8c21a5451d8 ("drm/etnaviv: add initial etnaviv DRM driver")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
drivers/gpu/drm/etnaviv/etnaviv_dump.c

index 3fbb4855396cc98505eeb2062de6579c01478d57..33854c94cb858f1cf62209e5f1c5e8d5de69e3e1 100644 (file)
@@ -215,7 +215,7 @@ void etnaviv_core_dump(struct etnaviv_gpu *gpu)
                mutex_lock(&obj->lock);
                pages = etnaviv_gem_get_pages(obj);
                mutex_unlock(&obj->lock);
-               if (pages) {
+               if (!IS_ERR(pages)) {
                        int j;
 
                        iter.hdr->data[0] = bomap - bomap_start;