]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
mac80211: bail out from prep_connection() if a reconfig is ongoing
authorLuca Coelho <luciano.coelho@intel.com>
Tue, 2 May 2017 14:56:21 +0000 (17:56 +0300)
committerJohannes Berg <johannes.berg@intel.com>
Mon, 8 May 2017 09:23:50 +0000 (11:23 +0200)
If ieee80211_hw_restart() is called during authentication, the
authentication process will continue, causing the driver to be called
in a wrong state.  This ultimately causes an oops in the iwlwifi
driver (at least).

This fixes bugzilla 195299 partly.

Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=195299
Signed-off-by: Luca Coelho <luciano.coelho@intel.com>
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
net/mac80211/mlme.c

index 89dff563b1ecf5eb938985143396cc1287bc9914..0ea9712bd99ea698f40b068d5ee31a69133224a3 100644 (file)
@@ -4382,6 +4382,10 @@ static int ieee80211_prep_connection(struct ieee80211_sub_if_data *sdata,
        if (WARN_ON(!ifmgd->auth_data && !ifmgd->assoc_data))
                return -EINVAL;
 
+       /* If a reconfig is happening, bail out */
+       if (local->in_reconfig)
+               return -EBUSY;
+
        if (assoc) {
                rcu_read_lock();
                have_sta = sta_info_get(sdata, cbss->bssid);