]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
pinctrl-sx150x: Remove magic numbers from sx150x_reset
authorAndrey Smirnov <andrew.smirnov@gmail.com>
Mon, 7 Nov 2016 16:53:23 +0000 (08:53 -0800)
committerLinus Walleij <linus.walleij@linaro.org>
Tue, 8 Nov 2016 08:48:49 +0000 (09:48 +0100)
Tested-by: Neil Armstrong <narmstrong@baylibre.com>
Acked-by: Neil Armstrong <narmstrong@baylibre.com>
Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
drivers/pinctrl/pinctrl-sx150x.c

index 56abe36071ed99ec5a65e1a670b2d877e9e76073..dc1341fdc73db99c726d9b2a7eb136675738deea 100644 (file)
@@ -49,6 +49,8 @@ enum {
        SX150X_MAX_REGISTER = 0xad,
        SX150X_IRQ_TYPE_EDGE_RISING = 0x1,
        SX150X_IRQ_TYPE_EDGE_FALLING = 0x2,
+       SX150X_789_RESET_KEY1 = 0x12,
+       SX150X_789_RESET_KEY2 = 0x34,
 };
 
 struct sx150x_123_pri {
@@ -771,13 +773,13 @@ static int sx150x_reset(struct sx150x_pinctrl *pctl)
 
        err = i2c_smbus_write_byte_data(pctl->client,
                                        pctl->data->pri.x789.reg_reset,
-                                       0x12);
+                                       SX150X_789_RESET_KEY1);
        if (err < 0)
                return err;
 
        err = i2c_smbus_write_byte_data(pctl->client,
                                        pctl->data->pri.x789.reg_reset,
-                                       0x34);
+                                       SX150X_789_RESET_KEY2);
        return err;
 }