]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
extcon: axp288: Add a depends on ACPI to the Kconfig entry
authorYueHaibing <yuehaibing@huawei.com>
Thu, 4 Apr 2019 14:17:48 +0000 (22:17 +0800)
committerChanwoo Choi <cw00.choi@samsung.com>
Thu, 11 Apr 2019 23:23:24 +0000 (08:23 +0900)
As Hans de Goede pointed, using this driver without ACPI
makes little sense, so add ACPI dependency to Kconfig entry
to fix a build error while CONFIG_ACPI is not set.

drivers/extcon/extcon-axp288.c: In function 'axp288_extcon_probe':
drivers/extcon/extcon-axp288.c:363:20: error: dereferencing pointer to incomplete type
    put_device(&adev->dev);

Fixes: 0cf064db948a ("extcon: axp288: Convert to use acpi_dev_get_first_match_dev()")
Reported-by: Hulk Robot <hulkci@huawei.com>
Suggested-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Reviewed-by: Mukesh Ojha <mojha@codeaurora.org>
Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com>
drivers/extcon/Kconfig

index 1ed4b45536c70da3c57517e0d3617df1acd397f2..de06fafb52ffc97d1f0e7a904ab20e1b7342c3f8 100644 (file)
@@ -30,7 +30,7 @@ config EXTCON_ARIZONA
 
 config EXTCON_AXP288
        tristate "X-Power AXP288 EXTCON support"
-       depends on MFD_AXP20X && USB_SUPPORT && X86
+       depends on MFD_AXP20X && USB_SUPPORT && X86 && ACPI
        select USB_ROLE_SWITCH
        help
          Say Y here to enable support for USB peripheral detection