media: ov8856: Check reading clock frequency succeeded

Instead of blindly trusting getting the clock frequency succeeded end then
testing it against a pre-defined value, verify reading the value
succeeded.

Fixes: 879347f0c258 ("media: ov8856: Add support for OV8856 sensor")
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>

diff --git a/drivers/media/i2c/ov8856.c b/drivers/media/i2c/ov8856.c
index cd347d6b7b9da5169778dd06bf015c98490bcf2f..8655842af2755886620480d1120f8d251b6d06f6 100644 (file)
--- a/drivers/media/i2c/ov8856.c
+++ b/drivers/media/i2c/ov8856.c
@@ -1106,7 +1106,10 @@ static int ov8856_check_hwcfg(struct device *dev)
        if (!fwnode)
                return -ENXIO;
 
-       fwnode_property_read_u32(fwnode, "clock-frequency", &mclk);
+       ret = fwnode_property_read_u32(fwnode, "clock-frequency", &mclk);
+       if (ret)
+               return ret;
+
        if (mclk != OV8856_MCLK) {
                dev_err(dev, "external clock %d is not supported", mclk);
                return -EINVAL;