]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
iwlwifi: remove dead code for internal devices only
authorEmmanuel Grumbach <emmanuel.grumbach@intel.com>
Tue, 17 Oct 2017 07:30:24 +0000 (10:30 +0300)
committerLuca Coelho <luciano.coelho@intel.com>
Fri, 3 Nov 2017 09:56:08 +0000 (11:56 +0200)
We had a bunch of code that was relevant for internal
devices only. Those devices are now being depreceated.
Kill all the now unneeded code.

Signed-off-by: Emmanuel Grumbach <emmanuel.grumbach@intel.com>
Signed-off-by: Luca Coelho <luciano.coelho@intel.com>
drivers/net/wireless/intel/iwlwifi/cfg/8000.c
drivers/net/wireless/intel/iwlwifi/fw/file.h
drivers/net/wireless/intel/iwlwifi/fw/img.h
drivers/net/wireless/intel/iwlwifi/iwl-config.h
drivers/net/wireless/intel/iwlwifi/iwl-csr.h
drivers/net/wireless/intel/iwlwifi/iwl-drv.c
drivers/net/wireless/intel/iwlwifi/iwl-trans.h
drivers/net/wireless/intel/iwlwifi/mvm/fw.c
drivers/net/wireless/intel/iwlwifi/mvm/mvm.h
drivers/net/wireless/intel/iwlwifi/mvm/ops.c

index 1dce74afcd752bd9b3d9b67d1bc6fdacffa7555e..9bb7c19d48eb4cc5171c05054333774cc0c52e06 100644 (file)
 #define NVM_HW_SECTION_NUM_FAMILY_8000         10
 #define DEFAULT_NVM_FILE_FAMILY_8000C          "nvmData-8000C"
 
-/* Max SDIO RX/TX aggregation sizes of the ADDBA request/response */
-#define MAX_RX_AGG_SIZE_8260_SDIO      21
-#define MAX_TX_AGG_SIZE_8260_SDIO      40
-
-/* Max A-MPDU exponent for HT and VHT */
-#define MAX_HT_AMPDU_EXPONENT_8260_SDIO        IEEE80211_HT_MAX_AMPDU_32K
-#define MAX_VHT_AMPDU_EXPONENT_8260_SDIO       IEEE80211_VHT_MAX_AMPDU_32K
-
 static const struct iwl_base_params iwl8000_base_params = {
        .eeprom_size = OTP_LOW_IMAGE_SIZE_FAMILY_8000,
        .num_of_queues = 31,
@@ -234,48 +226,5 @@ const struct iwl_cfg iwl4165_2ac_cfg = {
        .max_ht_ampdu_exponent = IEEE80211_HT_MAX_AMPDU_64K,
 };
 
-const struct iwl_cfg iwl8260_2ac_sdio_cfg = {
-       .name = "Intel(R) Dual Band Wireless-AC 8260",
-       .fw_name_pre = IWL8000_FW_PRE,
-       IWL_DEVICE_8260,
-       .ht_params = &iwl8000_ht_params,
-       .nvm_ver = IWL8000_NVM_VERSION,
-       .nvm_calib_ver = IWL8000_TX_POWER_VERSION,
-       .max_rx_agg_size = MAX_RX_AGG_SIZE_8260_SDIO,
-       .max_tx_agg_size = MAX_TX_AGG_SIZE_8260_SDIO,
-       .disable_dummy_notification = true,
-       .max_ht_ampdu_exponent  = MAX_HT_AMPDU_EXPONENT_8260_SDIO,
-       .max_vht_ampdu_exponent = MAX_VHT_AMPDU_EXPONENT_8260_SDIO,
-};
-
-const struct iwl_cfg iwl8265_2ac_sdio_cfg = {
-       .name = "Intel(R) Dual Band Wireless-AC 8265",
-       .fw_name_pre = IWL8265_FW_PRE,
-       IWL_DEVICE_8265,
-       .ht_params = &iwl8000_ht_params,
-       .nvm_ver = IWL8000_NVM_VERSION,
-       .nvm_calib_ver = IWL8000_TX_POWER_VERSION,
-       .max_rx_agg_size = MAX_RX_AGG_SIZE_8260_SDIO,
-       .max_tx_agg_size = MAX_TX_AGG_SIZE_8260_SDIO,
-       .disable_dummy_notification = true,
-       .max_ht_ampdu_exponent  = MAX_HT_AMPDU_EXPONENT_8260_SDIO,
-       .max_vht_ampdu_exponent = MAX_VHT_AMPDU_EXPONENT_8260_SDIO,
-};
-
-const struct iwl_cfg iwl4165_2ac_sdio_cfg = {
-       .name = "Intel(R) Dual Band Wireless-AC 4165",
-       .fw_name_pre = IWL8000_FW_PRE,
-       IWL_DEVICE_8000,
-       .ht_params = &iwl8000_ht_params,
-       .nvm_ver = IWL8000_NVM_VERSION,
-       .nvm_calib_ver = IWL8000_TX_POWER_VERSION,
-       .max_rx_agg_size = MAX_RX_AGG_SIZE_8260_SDIO,
-       .max_tx_agg_size = MAX_TX_AGG_SIZE_8260_SDIO,
-       .bt_shared_single_ant = true,
-       .disable_dummy_notification = true,
-       .max_ht_ampdu_exponent  = MAX_HT_AMPDU_EXPONENT_8260_SDIO,
-       .max_vht_ampdu_exponent = MAX_VHT_AMPDU_EXPONENT_8260_SDIO,
-};
-
 MODULE_FIRMWARE(IWL8000_MODULE_FIRMWARE(IWL8000_UCODE_API_MAX));
 MODULE_FIRMWARE(IWL8265_MODULE_FIRMWARE(IWL8265_UCODE_API_MAX));
index efd7fb65de8b30ea73dd551bfb6b97f7c1b01822..740d97093d1c5c8992b5f09f4274b445639de20b 100644 (file)
@@ -136,7 +136,7 @@ enum iwl_ucode_tlv_type {
        IWL_UCODE_TLV_N_SCAN_CHANNELS           = 31,
        IWL_UCODE_TLV_PAGING            = 32,
        IWL_UCODE_TLV_SEC_RT_USNIFFER   = 34,
-       IWL_UCODE_TLV_SDIO_ADMA_ADDR    = 35,
+       /* 35 is unused */
        IWL_UCODE_TLV_FW_VERSION        = 36,
        IWL_UCODE_TLV_FW_DBG_DEST       = 38,
        IWL_UCODE_TLV_FW_DBG_CONF       = 39,
index e6bc9cb60700f911d12e78670c697c4195986bc4..985496cc01d0f47b503f19d440c033cc1dbfd1d9 100644 (file)
@@ -138,11 +138,6 @@ struct fw_img {
        u32 paging_mem_size;
 };
 
-struct iwl_sf_region {
-       u32 addr;
-       u32 size;
-};
-
 /*
  * Block paging calculations
  */
@@ -257,7 +252,6 @@ enum iwl_fw_type {
  * @type: firmware type (&enum iwl_fw_type)
  * @cipher_scheme: optional external cipher scheme.
  * @human_readable: human readable version
- * @sdio_adma_addr: the default address to set for the ADMA in SDIO mode until
  *     we get the ALIVE from the uCode
  * @dbg_dest_tlv: points to the destination TLV for debug
  * @dbg_conf_tlv: array of pointers to configuration TLVs for debug
@@ -290,8 +284,6 @@ struct iwl_fw {
        struct iwl_fw_cipher_scheme cs[IWL_UCODE_MAX_CS];
        u8 human_readable[FW_VER_HUMAN_READABLE_SZ];
 
-       u32 sdio_adma_addr;
-
        struct iwl_fw_dbg_dest_tlv *dbg_dest_tlv;
        struct iwl_fw_dbg_conf_tlv *dbg_conf_tlv[FW_DBG_CONF_MAX];
        size_t dbg_conf_tlv_len[FW_DBG_CONF_MAX];
index 86a7960257503b1cf4c3d0dfa37b5ddb2f88a4dd..d1263a554420403d82d62c699f8e404c7f687757 100644 (file)
@@ -467,9 +467,6 @@ extern const struct iwl_cfg iwl8260_2ac_cfg;
 extern const struct iwl_cfg iwl8265_2ac_cfg;
 extern const struct iwl_cfg iwl8275_2ac_cfg;
 extern const struct iwl_cfg iwl4165_2ac_cfg;
-extern const struct iwl_cfg iwl8260_2ac_sdio_cfg;
-extern const struct iwl_cfg iwl8265_2ac_sdio_cfg;
-extern const struct iwl_cfg iwl4165_2ac_sdio_cfg;
 extern const struct iwl_cfg iwl9160_2ac_cfg;
 extern const struct iwl_cfg iwl9260_2ac_cfg;
 extern const struct iwl_cfg iwl9270_2ac_cfg;
index b03e0f975b5a4e5d34c2568792572ecf63f864bb..4f0d070eda54816dfdfd7ec8f67c6a2917942a4a 100644 (file)
 #define CSR_INT_BIT_FH_TX        (1 << 27) /* Tx DMA FH_INT[1:0] */
 #define CSR_INT_BIT_SCD          (1 << 26) /* TXQ pointer advanced */
 #define CSR_INT_BIT_SW_ERR       (1 << 25) /* uCode error */
-#define CSR_INT_BIT_PAGING       (1 << 24) /* SDIO PAGING */
 #define CSR_INT_BIT_RF_KILL      (1 << 7)  /* HW RFKILL switch GP_CNTRL[27] toggled */
 #define CSR_INT_BIT_CT_KILL      (1 << 6)  /* Critical temp (chip too hot) rfkill */
 #define CSR_INT_BIT_SW_RX        (1 << 3)  /* Rx, command responses */
                                 CSR_INT_BIT_HW_ERR  | \
                                 CSR_INT_BIT_FH_TX   | \
                                 CSR_INT_BIT_SW_ERR  | \
-                                CSR_INT_BIT_PAGING  | \
                                 CSR_INT_BIT_RF_KILL | \
                                 CSR_INT_BIT_SW_RX   | \
                                 CSR_INT_BIT_WAKEUP  | \
index ccdb247d68c5e4bc37aa87632d7725981ea8e99f..4b224d7d967cc3192a649778b5045f29429e43af 100644 (file)
@@ -1039,12 +1039,6 @@ static int iwl_parse_tlv_firmware(struct iwl_drv *drv,
                        drv->fw.img[usniffer_img].paging_mem_size =
                                paging_mem_size;
                        break;
-               case IWL_UCODE_TLV_SDIO_ADMA_ADDR:
-                       if (tlv_len != sizeof(u32))
-                               goto invalid_tlv_len;
-                       drv->fw.sdio_adma_addr =
-                               le32_to_cpup((__le32 *)tlv_data);
-                       break;
                case IWL_UCODE_TLV_FW_GSCAN_CAPA:
                        /*
                         * Don't return an error in case of a shorter tlv_len
index bba4f54cbbbb817212f10e6ab4638688b2d5a4b1..10d3306038864fa874388a7ed6b0fe78d6c5629f 100644 (file)
@@ -398,8 +398,6 @@ struct iwl_hcmd_arr {
  * @command_groups: array of command groups, each member is an array of the
  *     commands in the group; for debugging only
  * @command_groups_size: number of command groups, to avoid illegal access
- * @sdio_adma_addr: the default address to set for the ADMA in SDIO mode until
- *     we get the ALIVE from the uCode
  * @cb_data_offs: offset inside skb->cb to store transport data at, must have
  *     space for at least two pointers
  */
@@ -419,8 +417,6 @@ struct iwl_trans_config {
        const struct iwl_hcmd_arr *command_groups;
        int command_groups_size;
 
-       u32 sdio_adma_addr;
-
        u8 cb_data_offs;
 };
 
@@ -531,8 +527,6 @@ struct iwl_trans_ops {
        void (*op_mode_leave)(struct iwl_trans *iwl_trans);
        int (*start_fw)(struct iwl_trans *trans, const struct fw_img *fw,
                        bool run_in_rfkill);
-       int (*update_sf)(struct iwl_trans *trans,
-                        struct iwl_sf_region *st_fwrd_space);
        void (*fw_alive)(struct iwl_trans *trans, u32 scd_addr);
        void (*stop_device)(struct iwl_trans *trans, bool low_power);
 
@@ -828,17 +822,6 @@ static inline int iwl_trans_start_fw(struct iwl_trans *trans,
        return trans->ops->start_fw(trans, fw, run_in_rfkill);
 }
 
-static inline int iwl_trans_update_sf(struct iwl_trans *trans,
-                                     struct iwl_sf_region *st_fwrd_space)
-{
-       might_sleep();
-
-       if (trans->ops->update_sf)
-               return trans->ops->update_sf(trans, st_fwrd_space);
-
-       return 0;
-}
-
 static inline void _iwl_trans_stop_device(struct iwl_trans *trans,
                                          bool low_power)
 {
index 0296df625cd56efc9f2929631089a2a2acbdda2c..c0de7bb86cf7ea9fad58fb4a0c9aeff600385e7b 100644 (file)
@@ -196,8 +196,6 @@ static bool iwl_alive_fn(struct iwl_notif_wait_data *notif_wait,
                mvm->error_event_table[1] =
                        le32_to_cpu(lmac2->error_event_table_ptr);
        mvm->log_event_table = le32_to_cpu(lmac1->log_event_table_ptr);
-       mvm->sf_space.addr = le32_to_cpu(lmac1->st_fwrd_addr);
-       mvm->sf_space.size = le32_to_cpu(lmac1->st_fwrd_size);
 
        umac_error_event_table = le32_to_cpu(umac->error_info_addr);
 
@@ -266,7 +264,6 @@ static int iwl_mvm_load_ucode_wait_alive(struct iwl_mvm *mvm,
        int ret, i;
        enum iwl_ucode_type old_type = mvm->fwrt.cur_fw_img;
        static const u16 alive_cmd[] = { MVM_ALIVE };
-       struct iwl_sf_region st_fwrd_space;
 
        if (ucode_type == IWL_UCODE_REGULAR &&
            iwl_fw_dbg_conf_usniffer(mvm->fw, FW_DBG_START_FROM_ALIVE) &&
@@ -320,18 +317,6 @@ static int iwl_mvm_load_ucode_wait_alive(struct iwl_mvm *mvm,
                return -EIO;
        }
 
-       /*
-        * update the sdio allocation according to the pointer we get in the
-        * alive notification.
-        */
-       st_fwrd_space.addr = mvm->sf_space.addr;
-       st_fwrd_space.size = mvm->sf_space.size;
-       ret = iwl_trans_update_sf(mvm->trans, &st_fwrd_space);
-       if (ret) {
-               IWL_ERR(mvm, "Failed to update SF size. ret %d\n", ret);
-               return ret;
-       }
-
        iwl_trans_fw_alive(mvm->trans, alive_data.scd_base_addr);
 
        /*
index e34b3eb8e08b44a74d216abda810a48214ef5225..2f3d5bef4b9e0e1aba3880a3814ab2609cc64aca 100644 (file)
@@ -754,7 +754,6 @@ struct iwl_mvm {
        u32 log_event_table;
        u32 umac_error_event_table;
        bool support_umac_log;
-       struct iwl_sf_region sf_space;
 
        u32 ampdu_ref;
        bool ampdu_toggle;
index e82b4462722b52a343c1d83bc97c26ca7c83ba06..ce718e9c63ec17d66ab6315196f0eaef1471fa47 100644 (file)
@@ -703,7 +703,6 @@ iwl_op_mode_mvm_start(struct iwl_trans *trans, const struct iwl_cfg *cfg,
        trans_cfg.cb_data_offs = offsetof(struct ieee80211_tx_info,
                                          driver_data[2]);
 
-       trans_cfg.sdio_adma_addr = fw->sdio_adma_addr;
        trans_cfg.sw_csum_tx = IWL_MVM_SW_TX_CSUM_OFFLOAD;
 
        /* Set a short watchdog for the command queue */