]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
net: hns3: fix pause configure fail problem
authorHuazhong Tan <tanhuazhong@huawei.com>
Thu, 25 Apr 2019 12:42:52 +0000 (20:42 +0800)
committerDavid S. Miller <davem@davemloft.net>
Fri, 26 Apr 2019 16:13:28 +0000 (12:13 -0400)
When configure pause, current implementation returns directly
after setup PFC without setup BP, which is not sufficient.

So this patch fixes it, only return while setting PFC failed.

Fixes: 44e59e375bf7 ("net: hns3: do not return GE PFC setting err when initializing")
Signed-off-by: Huazhong Tan <tanhuazhong@huawei.com>
Signed-off-by: Peng Li <lipeng321@huawei.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_tm.c

index aafc69f4bfdd6f5d2afce29a7b3affb80b2f036c..a7bbb6d3091a62b185ea28c8fa39a6da8f0a7072 100644 (file)
@@ -1331,8 +1331,11 @@ int hclge_pause_setup_hw(struct hclge_dev *hdev, bool init)
        ret = hclge_pfc_setup_hw(hdev);
        if (init && ret == -EOPNOTSUPP)
                dev_warn(&hdev->pdev->dev, "GE MAC does not support pfc\n");
-       else
+       else if (ret) {
+               dev_err(&hdev->pdev->dev, "config pfc failed! ret = %d\n",
+                       ret);
                return ret;
+       }
 
        return hclge_tm_bp_setup(hdev);
 }