]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
slimbus: fix slim_tid_txn()
authorSrinivas Kandagatla <srinivas.kandagatla@linaro.org>
Sun, 18 Aug 2019 09:39:02 +0000 (10:39 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sun, 18 Aug 2019 10:56:10 +0000 (12:56 +0200)
fix below issue reported by coccicheck
./drivers/slimbus/slimbus.h:440:3-46: duplicated argument to && or ||

Looks like this was a typo, SLIM_MSG_MC_REQUEST_CHANGE_VALUE is command
which requires transaction ID, so fix it, this also fix the warning.

Reported-by: Hariprasad Kelam <hariprasad.kelam@gmail.com>
Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Link: https://lore.kernel.org/r/20190818093902.29993-3-srinivas.kandagatla@linaro.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/slimbus/slimbus.h

index 9be41089edde7385abd89b87385376d730be7d29..b2f013bfe42ef9205e577f996b580bbb3562a700 100644 (file)
@@ -439,7 +439,7 @@ static inline bool slim_tid_txn(u8 mt, u8 mc)
                (mc == SLIM_MSG_MC_REQUEST_INFORMATION ||
                 mc == SLIM_MSG_MC_REQUEST_CLEAR_INFORMATION ||
                 mc == SLIM_MSG_MC_REQUEST_VALUE ||
-                mc == SLIM_MSG_MC_REQUEST_CLEAR_INFORMATION));
+                mc == SLIM_MSG_MC_REQUEST_CHANGE_VALUE));
 }
 
 static inline bool slim_ec_txn(u8 mt, u8 mc)