]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
dmaengine: sprd: fix an NULL vs IS_ERR() bug
authorDan Carpenter <dan.carpenter@oracle.com>
Wed, 16 May 2018 08:48:07 +0000 (11:48 +0300)
committerVinod Koul <vkoul@kernel.org>
Thu, 17 May 2018 04:27:34 +0000 (09:57 +0530)
We recently cleaned this code up but we need to update the error
handling as well.  The devm_ioremap_resource() returns error pointers on
error, never NULL.

Fixes: e7f063ae1a31 ("dmaengine: sprd: Use devm_ioremap_resource() to map memory")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Baolin Wang <baolin.wang@linaro.org>
Signed-off-by: Vinod Koul <vkoul@kernel.org>
drivers/dma/sprd-dma.c

index e715d07aa632646c95dda50ef07bfb0eb242af21..36df3b096bbc2152acd3b13dd18d73d5d7cceb51 100644 (file)
@@ -808,8 +808,8 @@ static int sprd_dma_probe(struct platform_device *pdev)
 
        res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
        sdev->glb_base = devm_ioremap_resource(&pdev->dev, res);
-       if (!sdev->glb_base)
-               return -ENOMEM;
+       if (IS_ERR(sdev->glb_base))
+               return PTR_ERR(sdev->glb_base);
 
        dma_cap_set(DMA_MEMCPY, sdev->dma_dev.cap_mask);
        sdev->total_chns = chn_count;