]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
brcmfmac: set wpa_auth to WPA_AUTH_DISABLED in AP/OPEN security mode
authorWright Feng <wright.feng@cypress.com>
Thu, 3 Aug 2017 09:37:57 +0000 (17:37 +0800)
committerKalle Valo <kvalo@codeaurora.org>
Tue, 8 Aug 2017 11:51:07 +0000 (14:51 +0300)
When setting wpa_auth to WPA_AUTH_NONE(1) in AP mode with WEP security,
firmware will set privacy bit and add WPA OUI in VENDOR IE in beacon and
probe response. The security type in softAP beacons confuse the
supplicant in client side, and the user client will see [WPA-?] in
supplicant scan result. So we set WPA_AUTH_DISABLED in softAP mode with
OPEN security.

Signed-off-by: Wright Feng <wright.feng@cypress.com>
Acked-by: Arend van Spriel <arend.vanspriel@broadcom.com>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c

index 7e689c86d56576cf96ca755b16107216470fccdf..579089a340f6d065522e1b58281114562e2dcb79 100644 (file)
@@ -3940,6 +3940,7 @@ brcmf_cfg80211_flush_pmksa(struct wiphy *wiphy, struct net_device *ndev)
 static s32 brcmf_configure_opensecurity(struct brcmf_if *ifp)
 {
        s32 err;
+       s32 wpa_val;
 
        /* set auth */
        err = brcmf_fil_bsscfg_int_set(ifp, "auth", 0);
@@ -3954,7 +3955,11 @@ static s32 brcmf_configure_opensecurity(struct brcmf_if *ifp)
                return err;
        }
        /* set upper-layer auth */
-       err = brcmf_fil_bsscfg_int_set(ifp, "wpa_auth", WPA_AUTH_NONE);
+       if (brcmf_is_ibssmode(ifp->vif))
+               wpa_val = WPA_AUTH_NONE;
+       else
+               wpa_val = WPA_AUTH_DISABLED;
+       err = brcmf_fil_bsscfg_int_set(ifp, "wpa_auth", wpa_val);
        if (err < 0) {
                brcmf_err("wpa_auth error %d\n", err);
                return err;