ath10k: wait for vdev delete response from firmware

When we add an interface immediately after removing
the interface the vdev deletion in firmware might not
have been completed. We need to synchronize the vdev creation
with the firmware.

Wait for vdev delete response from firmware when we
remove an interface.

Tested HW: WCN3990
Tested FW: WLAN.HL.2.0-01188-QCAHLSWMTPLZ-1

Signed-off-by: Rakesh Pillai <pillair@codeaurora.org>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>

diff --git a/drivers/net/wireless/ath/ath10k/core.c b/drivers/net/wireless/ath/ath10k/core.c
index d5cb22e04a1e341f10213ef1fc3e0e65c5384437..c9aa90e1e56552e74f70bac07ce96356b6b10912 100644 (file)
--- a/drivers/net/wireless/ath/ath10k/core.c
+++ b/drivers/net/wireless/ath/ath10k/core.c
@@ -2,7 +2,7 @@
 /*
  * Copyright (c) 2005-2011 Atheros Communications Inc.
  * Copyright (c) 2011-2017 Qualcomm Atheros, Inc.
- * Copyright (c) 2018, The Linux Foundation. All rights reserved.
+ * Copyright (c) 2018-2019, The Linux Foundation. All rights reserved.
  */
 
 #include <linux/module.h>
@@ -2197,6 +2197,7 @@ static void ath10k_core_restart(struct work_struct *work)
        complete(&ar->offchan_tx_completed);
        complete(&ar->install_key_done);
        complete(&ar->vdev_setup_done);
+       complete(&ar->vdev_delete_done);
        complete(&ar->thermal.wmi_sync);
        complete(&ar->bss_survey_done);
        wake_up(&ar->htt.empty_tx_wq);
@@ -3163,6 +3164,7 @@ struct ath10k *ath10k_core_create(size_t priv_size, struct device *dev,
 
        init_completion(&ar->install_key_done);
        init_completion(&ar->vdev_setup_done);
+       init_completion(&ar->vdev_delete_done);
        init_completion(&ar->thermal.wmi_sync);
        init_completion(&ar->bss_survey_done);
 

diff --git a/drivers/net/wireless/ath/ath10k/core.h b/drivers/net/wireless/ath/ath10k/core.h
index fe6e88d2bdf943f36d4be2e3666767a38e20d988..872f13d0ba6458727da9565e9ef5a2bc9ae52ab5 100644 (file)
--- a/drivers/net/wireless/ath/ath10k/core.h
+++ b/drivers/net/wireless/ath/ath10k/core.h
@@ -2,7 +2,7 @@
 /*
  * Copyright (c) 2005-2011 Atheros Communications Inc.
  * Copyright (c) 2011-2017 Qualcomm Atheros, Inc.
- * Copyright (c) 2018, The Linux Foundation. All rights reserved.
+ * Copyright (c) 2018-2019, The Linux Foundation. All rights reserved.
  */
 
 #ifndef _CORE_H_
@@ -514,7 +514,8 @@ struct ath10k_sta {
        u32 peer_ps_state;
 };
 
-#define ATH10K_VDEV_SETUP_TIMEOUT_HZ (5 * HZ)
+#define ATH10K_VDEV_SETUP_TIMEOUT_HZ   (5 * HZ)
+#define ATH10K_VDEV_DELETE_TIMEOUT_HZ  (5 * HZ)
 
 enum ath10k_beacon_state {
        ATH10K_BEACON_SCHEDULED = 0,
@@ -1072,6 +1073,7 @@ struct ath10k {
 
        int last_wmi_vdev_start_status;
        struct completion vdev_setup_done;
+       struct completion vdev_delete_done;
 
        struct workqueue_struct *workqueue;
        /* Auxiliary workqueue */

diff --git a/drivers/net/wireless/ath/ath10k/mac.c b/drivers/net/wireless/ath/ath10k/mac.c
index c4e7adf3ae4538241d3ac40db623e45b08c6902b..572c03667110778492c525c0ae7d39b65617ed4a 100644 (file)
--- a/drivers/net/wireless/ath/ath10k/mac.c
+++ b/drivers/net/wireless/ath/ath10k/mac.c
@@ -1011,6 +1011,7 @@ static int ath10k_monitor_vdev_start(struct ath10k *ar, int vdev_id)
        arg.channel.max_antenna_gain = channel->max_antenna_gain * 2;
 
        reinit_completion(&ar->vdev_setup_done);
+       reinit_completion(&ar->vdev_delete_done);
 
        ret = ath10k_wmi_vdev_start(ar, &arg);
        if (ret) {
@@ -1060,6 +1061,7 @@ static int ath10k_monitor_vdev_stop(struct ath10k *ar)
                            ar->monitor_vdev_id, ret);
 
        reinit_completion(&ar->vdev_setup_done);
+       reinit_completion(&ar->vdev_delete_done);
 
        ret = ath10k_wmi_vdev_stop(ar, ar->monitor_vdev_id);
        if (ret)
@@ -1401,6 +1403,7 @@ static int ath10k_vdev_stop(struct ath10k_vif *arvif)
        lockdep_assert_held(&ar->conf_mutex);
 
        reinit_completion(&ar->vdev_setup_done);
+       reinit_completion(&ar->vdev_delete_done);
 
        ret = ath10k_wmi_vdev_stop(ar, arvif->vdev_id);
        if (ret) {
@@ -1437,6 +1440,7 @@ static int ath10k_vdev_start_restart(struct ath10k_vif *arvif,
        lockdep_assert_held(&ar->conf_mutex);
 
        reinit_completion(&ar->vdev_setup_done);
+       reinit_completion(&ar->vdev_delete_done);
 
        arg.vdev_id = arvif->vdev_id;
        arg.dtim_period = arvif->dtim_period;
@@ -5455,6 +5459,7 @@ static void ath10k_remove_interface(struct ieee80211_hw *hw,
        struct ath10k *ar = hw->priv;
        struct ath10k_vif *arvif = (void *)vif->drv_priv;
        struct ath10k_peer *peer;
+       unsigned long time_left;
        int ret;
        int i;
 
@@ -5496,6 +5501,15 @@ static void ath10k_remove_interface(struct ieee80211_hw *hw,
                ath10k_warn(ar, "failed to delete WMI vdev %i: %d\n",
                            arvif->vdev_id, ret);
 
+       if (test_bit(WMI_SERVICE_SYNC_DELETE_CMDS, ar->wmi.svc_map)) {
+               time_left = wait_for_completion_timeout(&ar->vdev_delete_done,
+                                                       ATH10K_VDEV_DELETE_TIMEOUT_HZ);
+               if (time_left == 0) {
+                       ath10k_warn(ar, "Timeout in receiving vdev delete response\n");
+                       goto out;
+               }
+       }
+
        /* Some firmware revisions don't notify host about self-peer removal
         * until after associated vdev is deleted.
         */
@@ -5546,6 +5560,7 @@ static void ath10k_remove_interface(struct ieee80211_hw *hw,
 
        ath10k_mac_txq_unref(ar, vif->txq);
 
+out:
        mutex_unlock(&ar->conf_mutex);
 }
 

diff --git a/drivers/net/wireless/ath/ath10k/wmi-tlv.c b/drivers/net/wireless/ath/ath10k/wmi-tlv.c
index 34e187486c63d3ea02c75efd8b2afa88e85e6a7e..13d66638dbb4ac7894bcc95ca8a3143fffd8802b 100644 (file)
--- a/drivers/net/wireless/ath/ath10k/wmi-tlv.c
+++ b/drivers/net/wireless/ath/ath10k/wmi-tlv.c
@@ -2,7 +2,7 @@
 /*
  * Copyright (c) 2005-2011 Atheros Communications Inc.
  * Copyright (c) 2011-2017 Qualcomm Atheros, Inc.
- * Copyright (c) 2018, The Linux Foundation. All rights reserved.
+ * Copyright (c) 2018-2019, The Linux Foundation. All rights reserved.
  */
 #include "core.h"
 #include "debug.h"
@@ -212,6 +212,13 @@ static int ath10k_wmi_tlv_event_bcn_tx_status(struct ath10k *ar,
        return 0;
 }
 
+static void ath10k_wmi_tlv_event_vdev_delete_resp(struct ath10k *ar,
+                                                 struct sk_buff *skb)
+{
+       ath10k_dbg(ar, ATH10K_DBG_WMI, "WMI_VDEV_DELETE_RESP_EVENTID\n");
+       complete(&ar->vdev_delete_done);
+}
+
 static int ath10k_wmi_tlv_event_diag_data(struct ath10k *ar,
                                          struct sk_buff *skb)
 {
@@ -514,6 +521,9 @@ static void ath10k_wmi_tlv_op_rx(struct ath10k *ar, struct sk_buff *skb)
        case WMI_TLV_VDEV_STOPPED_EVENTID:
                ath10k_wmi_event_vdev_stopped(ar, skb);
                break;
+       case WMI_TLV_VDEV_DELETE_RESP_EVENTID:
+               ath10k_wmi_tlv_event_vdev_delete_resp(ar, skb);
+               break;
        case WMI_TLV_PEER_STA_KICKOUT_EVENTID:
                ath10k_wmi_event_peer_sta_kickout(ar, skb);
                break;

diff --git a/drivers/net/wireless/ath/ath10k/wmi-tlv.h b/drivers/net/wireless/ath/ath10k/wmi-tlv.h
index bc3198b08844a295c974475c0a7895a7f73cf130..a4b1a1477e047ff8a1ff88643f313ddbcbe1df0d 100644 (file)
--- a/drivers/net/wireless/ath/ath10k/wmi-tlv.h
+++ b/drivers/net/wireless/ath/ath10k/wmi-tlv.h
@@ -2,7 +2,7 @@
 /*
  * Copyright (c) 2005-2011 Atheros Communications Inc.
  * Copyright (c) 2011-2017 Qualcomm Atheros, Inc.
- * Copyright (c) 2018, The Linux Foundation. All rights reserved.
+ * Copyright (c) 2018-2019, The Linux Foundation. All rights reserved.
  */
 #ifndef _WMI_TLV_H
 #define _WMI_TLV_H
@@ -301,6 +301,8 @@ enum wmi_tlv_event_id {
        WMI_TLV_VDEV_STOPPED_EVENTID,
        WMI_TLV_VDEV_INSTALL_KEY_COMPLETE_EVENTID,
        WMI_TLV_VDEV_MCC_BCN_INTERVAL_CHANGE_REQ_EVENTID,
+       WMI_TLV_VDEV_TSF_REPORT_EVENTID,
+       WMI_TLV_VDEV_DELETE_RESP_EVENTID,
        WMI_TLV_PEER_STA_KICKOUT_EVENTID = WMI_TLV_EV(WMI_TLV_GRP_PEER),
        WMI_TLV_PEER_INFO_EVENTID,
        WMI_TLV_PEER_TX_FAIL_CNT_THR_EVENTID,
@@ -1569,6 +1571,8 @@ wmi_tlv_svc_map(const __le32 *in, unsigned long *out, size_t len)
               WMI_SERVICE_MGMT_TX_WMI, len);
        SVCMAP(WMI_TLV_SERVICE_MESH_11S,
               WMI_SERVICE_MESH_11S, len);
+       SVCMAP(WMI_TLV_SERVICE_SYNC_DELETE_CMDS,
+              WMI_SERVICE_SYNC_DELETE_CMDS, len);
 }
 
 static inline void

diff --git a/drivers/net/wireless/ath/ath10k/wmi.h b/drivers/net/wireless/ath/ath10k/wmi.h
index bd54da64cd02ddd3b909917a1bf813d1cc56d7f0..8b869c289039ad392dcc3f836cde81948ac78a12 100644 (file)
--- a/drivers/net/wireless/ath/ath10k/wmi.h
+++ b/drivers/net/wireless/ath/ath10k/wmi.h
@@ -2,7 +2,7 @@
 /*
  * Copyright (c) 2005-2011 Atheros Communications Inc.
  * Copyright (c) 2011-2017 Qualcomm Atheros, Inc.
- * Copyright (c) 2018, The Linux Foundation. All rights reserved.
+ * Copyright (c) 2018-2019, The Linux Foundation. All rights reserved.
  */
 
 #ifndef _WMI_H_
@@ -200,6 +200,7 @@ enum wmi_service {
        WMI_SERVICE_RTT_RESPONDER_ROLE,
        WMI_SERVICE_PER_PACKET_SW_ENCRYPT,
        WMI_SERVICE_REPORT_AIRTIME,
+       WMI_SERVICE_SYNC_DELETE_CMDS,
 
        /* Remember to add the new value to wmi_service_name()! */
 
@@ -491,6 +492,7 @@ static inline char *wmi_service_name(enum wmi_service service_id)
        SVCSTR(WMI_SERVICE_RTT_RESPONDER_ROLE);
        SVCSTR(WMI_SERVICE_PER_PACKET_SW_ENCRYPT);
        SVCSTR(WMI_SERVICE_REPORT_AIRTIME);
+       SVCSTR(WMI_SERVICE_SYNC_DELETE_CMDS);
 
        case WMI_SERVICE_MAX:
                return NULL;