]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
r8169: don't check WoL when powering down PHY and interface is down
authorHeiner Kallweit <hkallweit1@gmail.com>
Sun, 24 Jun 2018 16:40:23 +0000 (18:40 +0200)
committerDavid S. Miller <davem@davemloft.net>
Mon, 25 Jun 2018 07:21:51 +0000 (16:21 +0900)
We can power down the PHY irregardless of WOL settings if interface
is down. So far we would have left the PHY enabled if WOL options
are set and the interface is brought down.

Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/realtek/r8169.c

index f8a1309a6494134ad5136dd08a22f4495278033c..1d33672c650df017a064c13d4c15239e38fbc34f 100644 (file)
@@ -4635,7 +4635,7 @@ static void rtl_wol_suspend_quirk(struct rtl8169_private *tp)
 
 static bool rtl_wol_pll_power_down(struct rtl8169_private *tp)
 {
-       if (!tp->saved_wolopts)
+       if (!netif_running(tp->dev) || !tp->saved_wolopts)
                return false;
 
        rtl_speed_down(tp);