]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
selftests/bpf: properly return error from bpf_flow_load
authorStanislav Fomichev <sdf@google.com>
Mon, 22 Apr 2019 15:55:51 +0000 (08:55 -0700)
committerDaniel Borkmann <daniel@iogearbox.net>
Tue, 23 Apr 2019 16:36:34 +0000 (18:36 +0200)
Right now we incorrectly return 'ret' which is always zero at that
point.

Signed-off-by: Stanislav Fomichev <sdf@google.com>
Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
tools/testing/selftests/bpf/flow_dissector_load.h

index eeb48b6fc827c7cd4ca7d485968952fbaf13fd9f..daeaeb5188940540bad2aaedc055a22bc6f550c7 100644 (file)
@@ -25,19 +25,19 @@ static inline int bpf_flow_load(struct bpf_object **obj,
 
        main_prog = bpf_object__find_program_by_title(*obj, section_name);
        if (!main_prog)
-               return ret;
+               return -1;
 
        *prog_fd = bpf_program__fd(main_prog);
        if (*prog_fd < 0)
-               return ret;
+               return -1;
 
        prog_array = bpf_object__find_map_by_name(*obj, map_name);
        if (!prog_array)
-               return ret;
+               return -1;
 
        prog_array_fd = bpf_map__fd(prog_array);
        if (prog_array_fd < 0)
-               return ret;
+               return -1;
 
        if (keys_map_name && keys_fd) {
                keys = bpf_object__find_map_by_name(*obj, keys_map_name);