]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
drm/amdgpu: Replace ttm_bo_unref with ttm_bo_put
authorThomas Zimmermann <tzimmermann@suse.de>
Tue, 31 Jul 2018 07:12:36 +0000 (09:12 +0200)
committerAlex Deucher <alexander.deucher@amd.com>
Tue, 31 Jul 2018 21:58:21 +0000 (16:58 -0500)
The function ttm_bo_put releases a reference to a TTM buffer object. The
function's name is more aligned to the Linux kernel convention of naming
ref-counting function _get and _put.

A call to ttm_bo_unref takes the address of the TTM BO object's pointer and
clears the pointer's value to NULL. This is not necessary in most cases and
sometimes even worked around by the calling code. A call to ttm_bo_put only
releases the reference without clearing the pointer.

The current behaviour of cleaning the pointer is kept in the calling code,
but should be removed if not required in a later patch.

v2:
 * set prefix to drm/amdgpu

Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
Reviewed-by: Christian König <christian.koenig@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/amdgpu/amdgpu_object.c

index f7ac9abf9cc1163f4717ff39d110fe6cf1031593..b0e14a3d54efd44e86580f816f41f05f16368b08 100644 (file)
@@ -843,9 +843,8 @@ void amdgpu_bo_unref(struct amdgpu_bo **bo)
                return;
 
        tbo = &((*bo)->tbo);
-       ttm_bo_unref(&tbo);
-       if (tbo == NULL)
-               *bo = NULL;
+       ttm_bo_put(tbo);
+       *bo = NULL;
 }
 
 /**