]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
staging: erofs: correct all misused ENOTSUPP
authorGao Xiang <gaoxiang25@huawei.com>
Wed, 14 Aug 2019 10:37:05 +0000 (18:37 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 15 Aug 2019 12:24:30 +0000 (14:24 +0200)
As Chao pointed out [1], ENOTSUPP is used for NFS
protocol only, we should use EOPNOTSUPP instead...

[1] https://lore.kernel.org/lkml/108ee2f9-75dd-b8ab-8da7-b81c17bafbf6@huawei.com/

Reported-by: Chao Yu <yuchao0@huawei.com>
Signed-off-by: Gao Xiang <gaoxiang25@huawei.com>
Reviewed-by: Chao Yu <yuchao0@huawei.com>
Link: https://lore.kernel.org/r/20190814103705.60698-3-gaoxiang25@huawei.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/erofs/decompressor.c
drivers/staging/erofs/internal.h
drivers/staging/erofs/xattr.c
drivers/staging/erofs/xattr.h
drivers/staging/erofs/zmap.c

index 5361a2bbedb6d1a9ffdbdd77d05e3aafbc67fbd3..32a811ac704ace1906e2129716d21c4027cc8bda 100644 (file)
@@ -124,7 +124,7 @@ static int lz4_decompress(struct z_erofs_decompress_req *rq, u8 *out)
        int ret;
 
        if (rq->inputsize > PAGE_SIZE)
-               return -ENOTSUPP;
+               return -EOPNOTSUPP;
 
        src = kmap_atomic(*rq->in);
        inputmargin = 0;
index 12f737cbc0c0b7e713b054fc571e3f02edfd7826..0e8d58546c528209e75c41e6dd48892a9f0e09c7 100644 (file)
@@ -403,12 +403,12 @@ int z_erofs_map_blocks_iter(struct inode *inode,
                            struct erofs_map_blocks *map,
                            int flags);
 #else
-static inline int z_erofs_fill_inode(struct inode *inode) { return -ENOTSUPP; }
+static inline int z_erofs_fill_inode(struct inode *inode) { return -EOPNOTSUPP; }
 static inline int z_erofs_map_blocks_iter(struct inode *inode,
                                          struct erofs_map_blocks *map,
                                          int flags)
 {
-       return -ENOTSUPP;
+       return -EOPNOTSUPP;
 }
 #endif /* !CONFIG_EROFS_FS_ZIP */
 
@@ -516,7 +516,7 @@ void *erofs_get_pcpubuf(unsigned int pagenr);
 #else
 static inline void *erofs_get_pcpubuf(unsigned int pagenr)
 {
-       return ERR_PTR(-ENOTSUPP);
+       return ERR_PTR(-EOPNOTSUPP);
 }
 
 #define erofs_put_pcpubuf(buf) do {} while (0)
index c5bfc9be412fd2244d1361c0d049ab4578b788be..e7e5840e3f9dbccfd798caff1ac37019479a90a3 100644 (file)
@@ -71,7 +71,7 @@ static int init_inode_xattrs(struct inode *inode)
        if (vi->xattr_isize == sizeof(struct erofs_xattr_ibody_header)) {
                errln("xattr_isize %d of nid %llu is not supported yet",
                      vi->xattr_isize, vi->nid);
-               ret = -ENOTSUPP;
+               ret = -EOPNOTSUPP;
                goto out_unlock;
        } else if (vi->xattr_isize < sizeof(struct erofs_xattr_ibody_header)) {
                if (unlikely(vi->xattr_isize)) {
index 63cc87e3d3f458e522657ea353de3d192cec1b68..e20249647541388ec7de373e32ddf7a17efd913f 100644 (file)
@@ -74,13 +74,13 @@ static inline int erofs_getxattr(struct inode *inode, int index,
                                 const char *name, void *buffer,
                                 size_t buffer_size)
 {
-       return -ENOTSUPP;
+       return -EOPNOTSUPP;
 }
 
 static inline ssize_t erofs_listxattr(struct dentry *dentry,
                                      char *buffer, size_t buffer_size)
 {
-       return -ENOTSUPP;
+       return -EOPNOTSUPP;
 }
 #endif /* !CONFIG_EROFS_FS_XATTR */
 
index 5551e615e8eaa64d5b1886c7e5acc476ebf26d84..b61b9b5950ac13f4ad8a344fa675fa839b46849e 100644 (file)
@@ -68,7 +68,7 @@ static int fill_inode_lazy(struct inode *inode)
        if (vi->z_algorithmtype[0] >= Z_EROFS_COMPRESSION_MAX) {
                errln("unknown compression format %u for nid %llu, please upgrade kernel",
                      vi->z_algorithmtype[0], vi->nid);
-               err = -ENOTSUPP;
+               err = -EOPNOTSUPP;
                goto unmap_done;
        }
 
@@ -79,7 +79,7 @@ static int fill_inode_lazy(struct inode *inode)
        if (vi->z_physical_clusterbits[0] != LOG_BLOCK_SIZE) {
                errln("unsupported physical clusterbits %u for nid %llu, please upgrade kernel",
                      vi->z_physical_clusterbits[0], vi->nid);
-               err = -ENOTSUPP;
+               err = -EOPNOTSUPP;
                goto unmap_done;
        }
 
@@ -211,7 +211,7 @@ static int unpack_compacted_index(struct z_erofs_maprecorder *m,
        else if (1 << amortizedshift == 2 && lclusterbits == 12)
                vcnt = 16;
        else
-               return -ENOTSUPP;
+               return -EOPNOTSUPP;
 
        encodebits = ((vcnt << amortizedshift) - sizeof(__le32)) * 8 / vcnt;
        base = round_down(eofs, vcnt << amortizedshift);
@@ -275,7 +275,7 @@ static int compacted_load_cluster_from_disk(struct z_erofs_maprecorder *m,
        int err;
 
        if (lclusterbits != 12)
-               return -ENOTSUPP;
+               return -EOPNOTSUPP;
 
        if (lcn >= totalidx)
                return -EINVAL;