]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
usb: dwc2: cleanup with list_first_entry_or_null()
authorMasahiro Yamada <yamada.masahiro@socionext.com>
Sun, 18 Sep 2016 16:03:13 +0000 (01:03 +0900)
committerFelipe Balbi <felipe.balbi@linux.intel.com>
Thu, 3 Nov 2016 08:38:36 +0000 (10:38 +0200)
The combo of list_empty() check and return list_first_entry()
can be replaced with list_first_entry_or_null().

Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Acked-by: John Youn <johnyoun@synopsys.com>
Signed-off-by: Felipe Balbi <felipe.balbi@linux.intel.com>
drivers/usb/dwc2/gadget.c

index 24fbebc9b409050092c8a54296c445f129422e83..9dc6c482b89e16fccd6d7ecb0037d6851f87c8b2 100644 (file)
@@ -1099,10 +1099,8 @@ static int dwc2_hsotg_ep_sethalt(struct usb_ep *ep, int value, bool now);
  */
 static struct dwc2_hsotg_req *get_ep_head(struct dwc2_hsotg_ep *hs_ep)
 {
-       if (list_empty(&hs_ep->queue))
-               return NULL;
-
-       return list_first_entry(&hs_ep->queue, struct dwc2_hsotg_req, queue);
+       return list_first_entry_or_null(&hs_ep->queue, struct dwc2_hsotg_req,
+                                       queue);
 }
 
 /**