]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
platform/chrome: wilco_ec: Fix unregistration order
authorDaniel Campello <campello@chromium.org>
Wed, 8 Jan 2020 16:35:20 +0000 (09:35 -0700)
committerEnric Balletbo i Serra <enric.balletbo@collabora.com>
Fri, 10 Jan 2020 10:42:51 +0000 (11:42 +0100)
The unregistration should happen in the opposite order of
the registration, so change it accordingly.

No real issue has been noticed, but it is good practice to
keep the correct unregistration order.

Signed-off-by: Daniel Campello <campello@chromium.org>
Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
drivers/platform/chrome/wilco_ec/core.c

index 5210c357feefd4159e4d774b3a0c3211fbfc2534..2d5f027d8770f83cadec21407524ca13290a1867 100644 (file)
@@ -137,9 +137,9 @@ static int wilco_ec_remove(struct platform_device *pdev)
 {
        struct wilco_ec_device *ec = platform_get_drvdata(pdev);
 
+       platform_device_unregister(ec->telem_pdev);
        platform_device_unregister(ec->charger_pdev);
        wilco_ec_remove_sysfs(ec);
-       platform_device_unregister(ec->telem_pdev);
        platform_device_unregister(ec->rtc_pdev);
        if (ec->debugfs_pdev)
                platform_device_unregister(ec->debugfs_pdev);