From: Hans de Goede Date: Mon, 18 Nov 2019 15:51:31 +0000 (+0100) Subject: drm/modes: parse_cmdline: Remove some unnecessary code (v2) X-Git-Tag: v5.6-rc1~114^2~16^2~57 X-Git-Url: https://asedeno.scripts.mit.edu/gitweb/?a=commitdiff_plain;ds=sidebyside;h=5b926617cdef41ce0696e09834991194b1759e28;p=linux.git drm/modes: parse_cmdline: Remove some unnecessary code (v2) fb_get_options() will return fb_mode_option if no video= argument is present on the kernel commandline, so there is no need to also do this in drm_mode_parse_command_line_for_connector() as our only caller uses fb_get_options() to get the mode_option argument. Changes in v2: -Split out the changes dealing with the initialization of the mode struct into a separate patch Acked-by: Maxime Ripard Signed-off-by: Hans de Goede Link: https://patchwork.freedesktop.org/patch/msgid/20191118155134.30468-10-hdegoede@redhat.com --- diff --git a/drivers/gpu/drm/drm_modes.c b/drivers/gpu/drm/drm_modes.c index 119fed7ab815..beb764efe6b3 100644 --- a/drivers/gpu/drm/drm_modes.c +++ b/drivers/gpu/drm/drm_modes.c @@ -1747,11 +1747,6 @@ bool drm_mode_parse_command_line_for_connector(const char *mode_option, mode->panel_orientation = DRM_MODE_PANEL_ORIENTATION_UNKNOWN; -#ifdef CONFIG_FB - if (!mode_option) - mode_option = fb_mode_option; -#endif - if (!mode_option) { mode->specified = false; return false;