From: Colin Ian King Date: Tue, 20 Dec 2016 21:23:30 +0000 (-0800) Subject: Input: synaptics-rmi4 - check for non zero version logically dead code X-Git-Tag: v4.11-rc1~102^2^2~13^2~6 X-Git-Url: https://asedeno.scripts.mit.edu/gitweb/?a=commitdiff_plain;h=0c54fe74db73499637315d6b3d83a7adbc6f32aa;p=linux.git Input: synaptics-rmi4 - check for non zero version logically dead code version is a u8, the check for version > 0 means that version can only be zero, so the subsequent check for version != 0 is never true and hence is redudant code and can be removed. Signed-off-by: Colin Ian King Signed-off-by: Dmitry Torokhov --- diff --git a/drivers/input/rmi4/rmi_f34.c b/drivers/input/rmi4/rmi_f34.c index 9774dfbab9bb..c3285cefe9b6 100644 --- a/drivers/input/rmi4/rmi_f34.c +++ b/drivers/input/rmi4/rmi_f34.c @@ -441,8 +441,6 @@ static int rmi_f34_probe(struct rmi_function *fn) /* v5 code only supported version 0, try V7 probe */ if (version > 0) return rmi_f34v7_probe(f34); - else if (version != 0) - return -ENODEV; f34->bl_version = 5;