From: Eric Dumazet <edumazet@google.com>
Date: Thu, 25 Apr 2019 00:21:40 +0000 (-0700)
Subject: tipc: remove rcu_read_unlock() left in tipc_udp_recv()
X-Git-Tag: v5.2-rc1~133^2~94
X-Git-Url: https://asedeno.scripts.mit.edu/gitweb/?a=commitdiff_plain;h=0e58156d700ac45fd5f0f90698a13233b1fe4c44;p=linux.git

tipc: remove rcu_read_unlock() left in tipc_udp_recv()

I forgot to remove one rcu_read_unlock() before a return statement.

Joy of mixing goto and return styles in a function :)

Fixes: 4109a2c3b91e ("tipc: tipc_udp_recv() cleanup vs rcu verbs")
Signed-off-by: Eric Dumazet <edumazet@google.com>
Reported-by: kbuild test robot <lkp@intel.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
---

diff --git a/net/tipc/udp_media.c b/net/tipc/udp_media.c
index 7413cbc9b638..0884a1b8ad12 100644
--- a/net/tipc/udp_media.c
+++ b/net/tipc/udp_media.c
@@ -360,7 +360,6 @@ static int tipc_udp_recv(struct sock *sk, struct sk_buff *skb)
 
 	if (b && test_bit(0, &b->up)) {
 		tipc_rcv(sock_net(sk), skb, b);
-		rcu_read_unlock();
 		return 0;
 	}