From: Andrzej Hajda Date: Tue, 23 Feb 2016 06:45:14 +0000 (+0100) Subject: ASoC: max9867: fix type of variable containing error codes X-Git-Tag: v4.6-rc1~101^2~9^2~5^5~2 X-Git-Url: https://asedeno.scripts.mit.edu/gitweb/?a=commitdiff_plain;h=127a9cbb5860a7cf15f4d4703ab0454e4603e8ac;p=linux.git ASoC: max9867: fix type of variable containing error codes value variable can contain error values and is compared with zero. Its type must be signed. The problem has been detected using coccinelle script scripts/coccinelle/tests/unsigned_lesser_than_zero.cocci Signed-off-by: Andrzej Hajda Reviewed-by: Axel Lin Signed-off-by: Mark Brown --- diff --git a/sound/soc/codecs/max9867.c b/sound/soc/codecs/max9867.c index ab7a94db8db7..4fb6fc7188c7 100755 --- a/sound/soc/codecs/max9867.c +++ b/sound/soc/codecs/max9867.c @@ -180,7 +180,8 @@ static int max9867_dai_hw_params(struct snd_pcm_substream *substream, { struct snd_soc_codec *codec = dai->codec; struct max9867_priv *max9867 = snd_soc_codec_get_drvdata(codec); - unsigned int ni_h, ni_l, value; + unsigned int ni_h, ni_l; + int value; value = get_ni_value(max9867->sysclk, params_rate(params)); if (value < 0)