From: Simon Tatham Date: Fri, 3 Feb 2017 19:33:50 +0000 (+0000) Subject: Fix an EOF-testing goof in winhandl.c. X-Git-Tag: 0.68~58 X-Git-Url: https://asedeno.scripts.mit.edu/gitweb/?a=commitdiff_plain;h=13d52fcb036ba52db597f49ea291cd6dd4105f43;p=PuTTY.git Fix an EOF-testing goof in winhandl.c. I was having a play with clang's MSVC compatibility mode, just to see how much of PuTTY it could compile, and one of its warnings pointed out this error which must have crept in when I was changing the EOF flags in winhandl.c from booleans to three-state enums - I left the ! on the front of what was previously an if (!thing) and needed to turn into if (thing == EOF_NO). --- diff --git a/windows/winhandl.c b/windows/winhandl.c index e5a5e2d5..cfd62987 100644 --- a/windows/winhandl.c +++ b/windows/winhandl.c @@ -533,7 +533,7 @@ void handle_write_eof(struct handle *h) * direction! */ assert(h->type == HT_OUTPUT); - if (!h->u.o.outgoingeof == EOF_NO) { + if (h->u.o.outgoingeof == EOF_NO) { h->u.o.outgoingeof = EOF_PENDING; handle_try_output(&h->u.o); }