From: Colin Ian King Date: Wed, 17 May 2017 21:58:50 +0000 (+0100) Subject: dmaengine: bcm-scm-raid: remove redundant null check on req X-Git-Tag: v4.13-rc1~91^2~6^2 X-Git-Url: https://asedeno.scripts.mit.edu/gitweb/?a=commitdiff_plain;h=1fc63cb4f1de790019d57ccaf3e9cd2e6abbc648;p=linux.git dmaengine: bcm-scm-raid: remove redundant null check on req Req is never null on at the point of the null check, so remove this redundant check and just return &req->tx. Detected by CoverityScan, CID#1436147 ("Logically dead code") Signed-off-by: Colin Ian King Signed-off-by: Vinod Koul --- diff --git a/drivers/dma/bcm-sba-raid.c b/drivers/dma/bcm-sba-raid.c index d6b927b960ab..e41bbc7cb094 100644 --- a/drivers/dma/bcm-sba-raid.c +++ b/drivers/dma/bcm-sba-raid.c @@ -582,7 +582,7 @@ sba_prep_dma_interrupt(struct dma_chan *dchan, unsigned long flags) req->tx.flags = flags; req->tx.cookie = -EBUSY; - return (req) ? &req->tx : NULL; + return &req->tx; } static void sba_fillup_memcpy_msg(struct sba_request *req,