From: Michał Mirosław <mirq-linux@rere.qmqm.pl>
Date: Thu, 21 Apr 2011 12:42:15 +0000 (+0000)
Subject: net: make WARN_ON in dev_disable_lro() useful
X-Git-Tag: v3.0-rc1~377^2~259
X-Git-Url: https://asedeno.scripts.mit.edu/gitweb/?a=commitdiff_plain;h=22d5969fb450afd3a4aff606360f7d52c5a3a628;p=linux.git

net: make WARN_ON in dev_disable_lro() useful

Signed-off-by: Michał Mirosław <mirq-linux@rere.qmqm.pl>
Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
---

diff --git a/net/core/dev.c b/net/core/dev.c
index 379c993ff421..541f22a035a2 100644
--- a/net/core/dev.c
+++ b/net/core/dev.c
@@ -1315,7 +1315,8 @@ void dev_disable_lro(struct net_device *dev)
 		return;
 
 	__ethtool_set_flags(dev, flags & ~ETH_FLAG_LRO);
-	WARN_ON(dev->features & NETIF_F_LRO);
+	if (unlikely(dev->features & NETIF_F_LRO))
+		netdev_WARN(dev, "failed to disable LRO!\n");
 }
 EXPORT_SYMBOL(dev_disable_lro);