From: Dan Carpenter <dan.carpenter@oracle.com>
Date: Mon, 11 Apr 2016 07:14:46 +0000 (+0300)
Subject: iommu/amd: Signedness bug in acpihid_device_group()
X-Git-Tag: v4.7-rc1~115^2^7~3
X-Git-Url: https://asedeno.scripts.mit.edu/gitweb/?a=commitdiff_plain;h=2d8e1f039de842701d35a857a7c5d9d47bc1c639;p=linux.git

iommu/amd: Signedness bug in acpihid_device_group()

"devid" needs to be signed for the error handling to work.

Fixes: b097d11a0fa3f ('iommu/amd: Manage iommu_group for ACPI HID devices')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Joerg Roedel <jroedel@suse.de>
---

diff --git a/drivers/iommu/amd_iommu.c b/drivers/iommu/amd_iommu.c
index c430c10fb645..12f77798a0a4 100644
--- a/drivers/iommu/amd_iommu.c
+++ b/drivers/iommu/amd_iommu.c
@@ -283,7 +283,7 @@ static struct iommu_dev_data *get_dev_data(struct device *dev)
 static struct iommu_group *acpihid_device_group(struct device *dev)
 {
 	struct acpihid_map_entry *p, *entry = NULL;
-	u16 devid;
+	int devid;
 
 	devid = get_acpihid_device_id(dev, &entry);
 	if (devid < 0)