From: Michael Hennerich Date: Tue, 13 Jul 2010 08:26:10 +0000 (+0000) Subject: Blackfin: portmux: fix peripheral map overflow when requesting pins X-Git-Tag: v2.6.36-rc1~310^2~11 X-Git-Url: https://asedeno.scripts.mit.edu/gitweb/?a=commitdiff_plain;h=382dbe5b39a4efa6fdb3e5093e5d0bdbb5c5301f;p=linux.git Blackfin: portmux: fix peripheral map overflow when requesting pins Some processors have groups of pins that aren't an even number of 16. This causes the array size calculation to under count the number of needed entries due to integer truncation. So on the BF51x, while we should have 3 bitmaps (41 / 16), we end up with 2 and pin requests for the 3rd bank end up scribbling over the top of the GPIO IRQ array. Signed-off-by: Michael Hennerich Signed-off-by: Mike Frysinger --- diff --git a/arch/blackfin/kernel/bfin_gpio.c b/arch/blackfin/kernel/bfin_gpio.c index c5650559a4e1..dc07ed08b37f 100644 --- a/arch/blackfin/kernel/bfin_gpio.c +++ b/arch/blackfin/kernel/bfin_gpio.c @@ -157,7 +157,7 @@ static int cmp_label(unsigned short ident, const char *label) #define DECLARE_RESERVED_MAP(m, c) static unsigned short reserved_##m##_map[c] DECLARE_RESERVED_MAP(gpio, GPIO_BANK_NUM); -DECLARE_RESERVED_MAP(peri, gpio_bank(MAX_RESOURCES)); +DECLARE_RESERVED_MAP(peri, DIV_ROUND_UP(MAX_RESOURCES, GPIO_BANKSIZE)); DECLARE_RESERVED_MAP(gpio_irq, GPIO_BANK_NUM); inline int check_gpio(unsigned gpio)